-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bash completion script #17147
base: main
Are you sure you want to change the base?
fix: bash completion script #17147
Conversation
This appears to work. But the whole bash completions feel buggy. I don't think it was this pr, but folders aren't autocompleting for me in Also |
Also just found out that there are other bun cli commands you can use instead of reading yourself. For example Lines 674 to 677 in c2edbe8
Lines 873 to 874 in c2edbe8
Line 920 in c2edbe8
Line 16 in c2edbe8
Line 24 in c2edbe8
Lines 1946 to 1962 in c2edbe8
|
Updated to use
Yeah, currently there are a lot of bugs, e.g. it can't complete a script which has |
i think its still a good improvement, only thing that i dont think is wise is full fix could be later |
OK, I have fixed to read package.json scripts only on |
What does this PR do?
#6037
Fixed the bash completion script to complete scripts in package.json.
local scripts="${matched%%\}*}";
didn't work if scripts contained}
characters.re_comp_word_script
was not defined, the condition( "${COMPREPLY[*]}" =~ ${re_comp_word_script} )
was always true and completions for scripts were removed.How did you verify your code works?
package.json
![image](https://private-user-images.githubusercontent.com/24248467/410947054-3531100a-60e6-43ff-b681-2075971053c9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mjg2ODAsIm5iZiI6MTczOTUyODM4MCwicGF0aCI6Ii8yNDI0ODQ2Ny80MTA5NDcwNTQtMzUzMTEwMGEtNjBlNi00M2ZmLWI2ODEtMjA3NTk3MTA1M2M5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDEwMTk0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg5YmU4MmM2YTE4ZTU2NDgyYjFkYmM0YzEyMDYzNTI3MDFiODc5Mjk4ZDIyZjIwOGI5MzZkMTQ3MjljY2I1MDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.sA7uUn9bnvsQ4PUcsRANcU018QVlXDPKNnUtmf1p0o4)