feat(node/net): add `SocketAddress` #17154

DonIsaac · 2025-02-07T20:58:47Z

What does this PR do?

Not ready for review. Creating a draft so tests can run.

Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes

TODO

swap out JSSocketAddress
lots of testing
Make sure it plays nicely with Listener

How did you verify your code works?

Lots of tests.

robobun · 2025-02-07T20:58:59Z

^{Updated 9:03 PM PT - Feb 10th, 2025}

❌ @DonIsaac, your commit c7045b4 has 6 failures in Build #11424:

test/js/bun/http/serve-body-leak.test.ts - 5 failing on 🐧 3.20 x64
test/js/bun/s3/s3.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 22.04 x64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 3.20 x64
test/js/node/test/parallel/test-http-client-input-function.js - code 1 on 🐧 3.20 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🍎 14 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 12 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 22.04 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 24.04 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 20.04 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🍎 14 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🍎 13 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 3.20 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 24.04 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 20.04 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 22.04 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 12 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 12 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 22.04 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 24.04 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 20.04 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🍎 13 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 3.20 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 3.20 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🍎 14 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🍎 14 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🍎 13 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 20.04 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 24.04 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 12 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 22.04 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 3.20 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 22.04 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 20.04 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 12 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 24.04 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🍎 13 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 22.04 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 24.04 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 12 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 20.04 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 3.20 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 3.20 x64-baseline
test/js/bun/http/serve.test.ts - 3 failing on 🍎 14 aarch64
test/js/bun/http/serve.test.ts - 3 failing on 🍎 14 x64
test/js/bun/http/serve.test.ts - 3 failing on 🍎 13 x64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 12 aarch64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 20.04 aarch64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 24.04 aarch64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 22.04 aarch64
test/js/bun/http/serve.test.ts - 3 failing on 🍎 13 aarch64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 3.20 aarch64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 22.04 x64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 24.04 x64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 20.04 x64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 12 x64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 24.04 x64-baseline
test/js/bun/http/serve.test.ts - 2 failing on 🐧 22.04 x64-baseline
test/js/bun/http/serve.test.ts - 2 failing on 🐧 12 x64-baseline
test/js/bun/http/serve.test.ts - 2 failing on 🐧 20.04 x64-baseline
test/js/bun/http/serve.test.ts - 2 failing on 🐧 3.20 x64
test/js/bun/http/serve.test.ts - 2 failing on 🐧 3.20 x64-baseline

🧪 try this PR locally:

bunx bun-pr 17154

src/bun.js/api/bun/socket/SocketAddress.zig

DonIsaac · 2025-02-08T02:05:47Z

src/bun.js/api/bun/socket/SocketAddress.zig

+
+pub fn getAddress(this: *SocketAddress, global: *JSC.JSGlobalObject) JSC.JSValue {
+    // TODO: check that this doesn't ref() again.
+    return this.address().toJS(global);


double-ref?

src/bun.js/api/bun/socket/SocketAddress.zig

DonIsaac · 2025-02-08T02:07:31Z

src/bun.js/bindings/ZigGlobalObject.cpp

@@ -2920,10 +2919,10 @@ void GlobalObject::finishCreation(VM& vm)
                    init.vm, reinterpret_cast<Zig::GlobalObject*>(init.owner)));
        });

-    m_JSSocketAddressStructure.initLater(


do zig codegen'd classes also have their structures cached?

DonIsaac · 2025-02-08T02:08:20Z

src/bun.js/bindings/bindings.zig

+        errno: ?i32 = null,
+        name: ?string = null,
+    };
+    pub fn throwSysError(


global.throwValue(bun.sys.Error.fromCode(errno, syscall).toJSC(global))

DonIsaac · 2025-02-08T02:18:46Z

OFC Windows doesn't have socklen_t. Needs to be swapped out with c_ares.socklen_t

DonIsaac added 3 commits February 7, 2025 10:37

wip: start net.SocketAddress

95f8f7e

wip. need to use sockaddr_storage

eb97edb

make it available to js

087e768

DonIsaac added enhancement New feature or request node:net labels Feb 7, 2025

DonIsaac and others added 2 commits February 7, 2025 21:00

bun run zig-format

7fdfb3f

move SocketAddress to bun.js/api and replace JSSocketAddress

5eb5885

DonIsaac commented Feb 8, 2025

View reviewed changes

src/bun.js/api/bun/socket/SocketAddress.zig Outdated Show resolved Hide resolved

DonIsaac commented Feb 8, 2025

View reviewed changes

src/bun.js/api/bun/socket/SocketAddress.zig Show resolved Hide resolved

DonIsaac commented Feb 8, 2025

View reviewed changes

DonIsaac and others added 13 commits February 10, 2025 10:38

cleanup

23ebb03

Merge branch 'main' of github.com:oven-sh/bun into don/feat/net-sockaddr

00351d3

fix socklen_t

7a1eed0

remove isSocketAddress from native impl

3a6d1ec

add SocketAddress wrapper

0ef8cb5

fix: invalid sentinel access when parsing addresses

070fa0b

updates tests + cleanup

f08c06b

make validation match node

08836f5

maybe windows is happy now?

2ca38f7

bun run zig-format

2cd75fd

cleanup

2ba3f58

UAF in server.getAddress

14787b1

bun run zig-format

a38d999

DonIsaac changed the title ~~[wip] feat(node/net): add SocketAddress~~ feat(node/net): add SocketAddress Feb 11, 2025

DonIsaac added 2 commits February 10, 2025 21:51

Merge branch 'main' of github.com:oven-sh/bun into don/feat/net-sockaddr

174001c

here we go again

c7045b4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(node/net): add `SocketAddress` #17154

feat(node/net): add `SocketAddress` #17154

DonIsaac commented Feb 7, 2025 •

edited

Loading

robobun commented Feb 7, 2025 •

edited

Loading

DonIsaac Feb 8, 2025

DonIsaac Feb 8, 2025

DonIsaac Feb 8, 2025

DonIsaac commented Feb 8, 2025

feat(node/net): add SocketAddress #17154

Are you sure you want to change the base?

feat(node/net): add SocketAddress #17154

Conversation

DonIsaac commented Feb 7, 2025 • edited Loading

What does this PR do?

TODO

How did you verify your code works?

robobun commented Feb 7, 2025 • edited Loading

DonIsaac Feb 8, 2025

Choose a reason for hiding this comment

DonIsaac Feb 8, 2025

Choose a reason for hiding this comment

DonIsaac Feb 8, 2025

Choose a reason for hiding this comment

DonIsaac commented Feb 8, 2025

feat(node/net): add `SocketAddress` #17154

feat(node/net): add `SocketAddress` #17154

DonIsaac commented Feb 7, 2025 •

edited

Loading

robobun commented Feb 7, 2025 •

edited

Loading