fix: __dirname and __filename collisions #17222
Open
+65
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves issues with
__dirname
and__filename
collisions (#17188) by creating unique variables when__dirname
or__filename
are used in a bundle.How did you verify your code works?
bun-debug test test-file-name.test
)Reproduction
When multiple files utilize
__dirname
/__filename
Bun hoists the values to the top of the module code. However, since it is avar
it can be overwritten effectively making it so only__dirname
/__filename
values collide.Before
In this single JS output,
__dirname
ends up evaluating to/Users/anthony/dev/test
in both places it is called because that is the last value the var is assigned to.After
The collision no longer occurs because usages of
__dirname
and__filename
get unique values.