Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler): bundling invalid html / export star as / react refresh fixes #17685

Merged
merged 13 commits into from
Feb 26, 2025

Conversation

paperclover
Copy link
Member

@paperclover paperclover commented Feb 25, 2025

Fixes #17554
Fixes #17564
Fixes #17566

the invalid html caused a crash because the dev server did not know where to inject script and style tags. this removes the body tag code since i decided to inject everything into head

@robobun
Copy link

robobun commented Feb 25, 2025

Updated 12:26 AM PT - Feb 26th, 2025

@paperclover, your commit 67456dd has 2 failures in Build #12292:


🧪   try this PR locally:

bunx bun-pr 17685

@paperclover paperclover requested a review from DonIsaac February 25, 2025 22:49
@paperclover paperclover marked this pull request as draft February 25, 2025 23:40
@DonIsaac DonIsaac linked an issue Feb 26, 2025 that may be closed by this pull request
@DonIsaac DonIsaac added the bundler Something to do with the bundler label Feb 26, 2025
@DonIsaac DonIsaac changed the title fix bundling html with invalid html / missing body or head tags fix(bundler): bundling html with invalid html / missing body or head tags Feb 26, 2025
@paperclover paperclover changed the title fix(bundler): bundling html with invalid html / missing body or head tags fix(bundler): bundling invalid html / multiple rfr hook signatures Feb 26, 2025
@paperclover paperclover marked this pull request as ready for review February 26, 2025 01:53
@paperclover paperclover changed the title fix(bundler): bundling invalid html / multiple rfr hook signatures fix(bundler): bundling invalid html / export star as / react refresh fixes Feb 26, 2025
@paperclover paperclover merged commit ac8fb0e into main Feb 26, 2025
67 of 70 checks passed
@paperclover paperclover deleted the chloe/hmr8 branch February 26, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundler Something to do with the bundler
Projects
None yet
3 participants