node:crypto: move Sign and Verify to c++

[dylan-conway]

What does this PR do?

Uses ncrypto for implementing Sign

How did you verify your code works?

[robobun]

^{Updated 1:56 AM PT - Mar 1st, 2025}

❌ @dylan-conway, your commit c863bf8 has some failures in Build #12558

---

🧪   try this PR locally:

bunx bun-pr 17692

[Copilot]

PR Overview

This PR moves the Sign implementation to C++ by integrating ncrypto, refactors related crypto API functions, and updates error codes.

• Updates test behavior for missing crypto support and OpenSSL version detection
• Refactors crypto.ts to create a new Sign class and update key processing functions
• Adds new error codes in ErrorCode.ts to support the new crypto functionality

Reviewed Changes

File	Description
test/js/node/test/common/crypto.js	Wraps the crypto test skip logic in braces and adds OpenSSL version helpers
src/js/node/crypto.ts	Refactors crypto functions, adds a new Sign class, and updates key handling
src/bun.js/bindings/ErrorCode.ts	Introduces new error mappings for crypto sign and key compatibility

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/js/node/crypto.ts:231

• [nitpick] The optional parameter 'encoding' lacks an explicit type annotation, which may reduce type safety in a TypeScript context. Consider defining its type explicitly (e.g. encoding?: string).

function getArrayBufferOrView(buffer, name, encoding?) {

[Copilot]

The regex match on process.versions.openssl does not check for a null result, which could lead to a runtime error if the version string format changes. Consider adding a null check before destructuring the groups.

Suggested change

	const { m, n, p } = process.versions.openssl.match(regexp).groups;
	OPENSSL_VERSION_NUMBER = opensslVersionNumber(m, n, p);
	const match = process.versions.openssl.match(regexp);
	if (match) {
	const { m, n, p } = match.groups;
	OPENSSL_VERSION_NUMBER = opensslVersionNumber(m, n, p);
	} else {
	throw new Error('Invalid OpenSSL version format');
	}

[dylan-conway]

Do I need to make this change in other places in this file?