Implement node:crypto DiffieHellman (in native code)

[Jarred-Sumner]

What does this PR do?

This is a draft. Some of the argument validation isn't precisely correct. The node_crypto_dh.zig code is silly.

How did you verify your code works?

[robobun]

^{Updated 1:53 AM PT - Mar 2nd, 2025}

❌ @Jarred-Sumner, your commit c36c2c6 has 39 failures in Build #12568:

• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🪟 2019 x64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🪟 2019 x64-baseline
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 22.04 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 20.04 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 12 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 24.04 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 3.20 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🍎 13 x64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🍎 13 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🍎 14 x64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🍎 14 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 24.04 x64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 20.04 x64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 22.04 x64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 20.04 x64-baseline
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 22.04 x64-baseline
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 12 x64
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 12 x64-baseline
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 24.04 x64-baseline
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 3.20 x64-baseline
• test/js/third_party/mongodb/mongodb.test.ts - annotation error on 🐧 3.20 x64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🪟 2019 x64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🪟 2019 x64-baseline
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 24.04 aarch64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 12 aarch64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 22.04 aarch64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 20.04 aarch64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🍎 13 aarch64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🍎 14 aarch64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 3.20 aarch64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 22.04 x64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 24.04 x64-baseline
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 12 x64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 24.04 x64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 20.04 x64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 22.04 x64-baseline
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 20.04 x64-baseline
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 12 x64-baseline
• test/js/third_party/postgres/postgres.test.ts - timeout on 🍎 13 x64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🍎 14 x64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 3.20 x64
• test/js/third_party/postgres/postgres.test.ts - timeout on 🐧 3.20 x64-baseline
• test/integration/mysql2/mysql2.test.ts - 2 failing on 🐧 24.04 aarch64
• test/integration/mysql2/mysql2.test.ts - 2 failing on 🐧 22.04 aarch64
• test/integration/mysql2/mysql2.test.ts - 2 failing on 🐧 20.04 aarch64
• test/integration/mysql2/mysql2.test.ts - 2 failing on 🐧 24.04 x64
• test/integration/mysql2/mysql2.test.ts - 2 failing on 🐧 22.04 x64-baseline
• test/integration/mysql2/mysql2.test.ts - 2 failing on 🐧 20.04 x64
• test/integration/mysql2/mysql2.test.ts - 2 failing on 🐧 22.04 x64
• test/integration/mysql2/mysql2.test.ts - 2 failing on 🐧 24.04 x64-baseline
• test/integration/mysql2/mysql2.test.ts - 2 failing on 🐧 20.04 x64-baseline
• test/js/bun/util/escapeHTML.test.js - segmentation fault on 🐧 12 aarch64
• test/js/bun/util/escapeHTML.test.js - segmentation fault on 🐧 3.20 aarch64
• test/js/bun/util/escapeHTML.test.js - SIGTRAP on 🍎 13 x64
• test/js/node/test/parallel/test-crypto-sign-verify.js - code 1 on 🐧 12 aarch64
• test/js/node/test/parallel/test-crypto-sign-verify.js - code 1 on 🐧 20.04 aarch64
• test/js/node/test/parallel/test-crypto-sign-verify.js - code 1 on 🐧 24.04 aarch64
• test/js/node/test/parallel/test-crypto-sign-verify.js - code 1 on 🐧 22.04 aarch64
• test/js/node/test/parallel/test-crypto-sign-verify.js - code 1 on 🐧 3.20 aarch64
• test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 13 x64
• test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 12 x64
• test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 20.04 x64
• test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 12 x64-baseline
• test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
• test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
• test/js/node/test/parallel/test-string-decoder-fuzz.js - segmentation fault at address 0x24 on 🪟 2019 x64-baseline
• test/js/node/test/parallel/test-string-decoder-fuzz.js - code STATUS_HEAP_CORRUPTION on 🪟 2019 x64
• test/js/node/test/parallel/test-string-decoder-fuzz.js - segmentation fault at address 0x1c5 on 🍎 13 aarch64
• test/js/node/test/parallel/test-string-decoder-fuzz.js - segmentation fault at address 0x200000042 on 🐧 22.04 aarch64
• test/js/node/test/parallel/test-string-decoder-fuzz.js - segmentation fault at address 0x7f3e on 🐧 12 x64
• test/js/node/test/parallel/test-string-decoder-fuzz.js - segmentation fault at address 0x0 on 🐧 20.04 x64
• test/js/node/test/parallel/test-string-decoder-fuzz.js - segmentation fault at address 0x0 on 🐧 20.04 x64-baseline
• test/js/node/test/parallel/test-string-decoder-fuzz.js - segmentation fault at address 0x0 on 🐧 22.04 x64-baseline
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🪟 2019 x64-baseline
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🍎 13 aarch64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🍎 14 aarch64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🪟 2019 x64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 22.04 aarch64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 20.04 aarch64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 12 aarch64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 24.04 aarch64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 3.20 aarch64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 24.04 x64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 12 x64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 22.04 x64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 24.04 x64-baseline
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 20.04 x64-baseline
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 20.04 x64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 22.04 x64-baseline
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 12 x64-baseline
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 3.20 x64
• test/js/node/test/parallel/test-crypto-dh-shared.js - code 1 on 🐧 3.20 x64-baseline
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🪟 2019 x64-baseline
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🪟 2019 x64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🍎 13 aarch64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🍎 14 aarch64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 12 aarch64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 20.04 aarch64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 24.04 aarch64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 22.04 aarch64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 3.20 aarch64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 12 x64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 12 x64-baseline
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 22.04 x64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 20.04 x64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 24.04 x64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 22.04 x64-baseline
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 20.04 x64-baseline
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 24.04 x64-baseline
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 3.20 x64
• test/js/node/test/parallel/test-crypto-dh.js - code 1 on 🐧 3.20 x64-baseline
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🪟 2019 x64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🪟 2019 x64-baseline
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🍎 14 aarch64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🍎 13 aarch64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 22.04 aarch64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 20.04 aarch64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 12 aarch64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 24.04 aarch64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 3.20 aarch64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 24.04 x64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 20.04 x64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 12 x64-baseline
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 12 x64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 22.04 x64
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 22.04 x64-baseline
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 24.04 x64-baseline
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 20.04 x64-baseline
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 3.20 x64-baseline
• test/js/node/test/parallel/test-buffer-tostring-range.js - code 1 on 🐧 3.20 x64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🪟 2019 x64-baseline
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🪟 2019 x64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 20.04 aarch64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 12 aarch64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 24.04 aarch64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 22.04 aarch64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 3.20 aarch64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🍎 13 x64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🍎 14 x64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🍎 13 aarch64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🍎 14 aarch64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 22.04 x64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 12 x64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 20.04 x64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 24.04 x64
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 24.04 x64-baseline
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 12 x64-baseline
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 22.04 x64-baseline
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 20.04 x64-baseline
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 3.20 x64-baseline
• test/js/third_party/grpc-js/test-local-subchannel-pool.test.ts - 1 failing on 🐧 3.20 x64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🪟 2019 x64-baseline
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🪟 2019 x64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🍎 13 aarch64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🍎 14 aarch64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 12 aarch64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 20.04 aarch64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 22.04 aarch64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 24.04 aarch64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 3.20 aarch64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 22.04 x64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 12 x64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 24.04 x64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 12 x64-baseline
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 20.04 x64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 24.04 x64-baseline
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 22.04 x64-baseline
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 20.04 x64-baseline
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🍎 13 x64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🍎 14 x64
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 3.20 x64-baseline
• test/js/third_party/grpc-js/test-server.test.ts - annotation error on 🐧 3.20 x64
• test/js/node/buffer.test.js - 26 failing on 🪟 2019 x64-baseline
• test/js/node/buffer.test.js - code STATUS_HEAP_CORRUPTION on 🪟 2019 x64
• test/js/node/buffer.test.js - 26 failing on 🍎 14 aarch64
• test/js/node/buffer.test.js - 26 failing on 🍎 13 aarch64
• test/js/node/buffer.test.js - 26 failing on 🐧 22.04 aarch64
• test/js/node/buffer.test.js - 26 failing on 🐧 20.04 aarch64
• test/js/node/buffer.test.js - 26 failing on 🐧 12 aarch64
• test/js/node/buffer.test.js - 26 failing on 🐧 24.04 aarch64
• test/js/node/buffer.test.js - 26 failing on 🐧 3.20 aarch64
• test/js/node/buffer.test.js - 26 failing on 🍎 13 x64
• test/js/node/buffer.test.js - 26 failing on 🍎 14 x64
• test/js/node/buffer.test.js - 26 failing on 🐧 24.04 x64
• test/js/node/buffer.test.js - 26 failing on 🐧 22.04 x64
• test/js/node/buffer.test.js - 26 failing on 🐧 12 x64
• test/js/node/buffer.test.js - 26 failing on 🐧 12 x64-baseline
• test/js/node/buffer.test.js - 26 failing on 🐧 20.04 x64
• test/js/node/buffer.test.js - 26 failing on 🐧 22.04 x64-baseline
• test/js/node/buffer.test.js - 26 failing on 🐧 24.04 x64-baseline
• test/js/node/buffer.test.js - 26 failing on 🐧 20.04 x64-baseline
• test/js/node/buffer.test.js - 26 failing on 🐧 3.20 x64-baseline
• test/js/node/buffer.test.js - 26 failing on 🐧 3.20 x64

---

🧪   try this PR locally:

bunx bun-pr 17850