vscode extention - support test names with special characters #17915
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiskyMH
changed the title
RiskyMH
approved these changes
Mar 5, 2025
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This escapes test names when running them via the VsCode CodeLens commands "Run Test" or "Watch Test". With this change, tests with names like
parse {orsomething (something)run as expected, instead of failing the runner in the former case or getting skipped in the latter case.How did you verify your code works?
Manual testing. Added a test called
can run with special chars :)to the extension's example project, and verified that it's being run when clicking the "Run Test" action.Screen.Recording.2025-03-05.at.11.57.38.mov
The VsCode extension isn't covered by CI tests, and a PR like this doesn't seem like the place to introduce them.