Add console logs to dev server inspector#19404
Open
zackradisic wants to merge 10 commits intomainfrom
Open
Conversation
Collaborator
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+303
to
+304
| function websocketInspect(logLevel: "l" | "e", values: any[]) { | ||
| let str = "l" + logLevel; |
Contributor
There was a problem hiding this comment.
The protocol implementation appears to have a small inconsistency. In the websocketInspect function, the message format starts with "l" + logLevel, creating strings like "ll" or "le". However, according to the IncomingMessageId enum in DevServer.zig, the first character should be the message type identifier ('l' for console_log), followed by the log kind.
This double 'l' prefix might be intentional as part of the protocol design, but it's worth confirming that the server-side handler in DevServer.zig correctly expects this format with the duplicated 'l' character at the beginning of console log messages.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
console.logandconsole.errorget added to dev server inspector protocolAdded a test