Conversation
Collaborator
|
Updated 1:02 PM PT - Jul 25th, 2025
@cirospaciari, your commit 3123c2b is building: |
pfgithub
requested review from
a team,
190n and
alii
and removed request for
a team
190n
suggested changes
May 1, 2025
Jarred-Sumner
requested changes
May 1, 2025
Collaborator
Jarred-Sumner
left a comment
Jarred-Sumner
left a comment
There was a problem hiding this comment.
Assuming this is run in the server as well as the client, then we should do this in C++ and not in JS. If this is only in the client, it's fine though.
Jarred-Sumner
previously approved these changes
May 2, 2025
cirospaciari
reviewed
May 2, 2025
Member
cirospaciari
left a comment
cirospaciari
left a comment
There was a problem hiding this comment.
I believe this PR don't fully fixes the node.js test (because fetch limitations right now) but do significant work to improve it, would open a Issue for this to remember us to remove the Bun undefined checks.
190n
suggested changes
May 7, 2025
Contributor
190n
left a comment
190n
left a comment
There was a problem hiding this comment.
Delete a.js, otherwise LGTM
190n
previously approved these changes
May 7, 2025
cirospaciari
approved these changes
May 14, 2025
190n
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.