Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bun-release): support windows in npm package #9873

Merged
merged 8 commits into from
Apr 4, 2024

Conversation

paperclover
Copy link
Member

@paperclover paperclover commented Apr 3, 2024

Fixes #9783

There was no work done testing the npm package on Windows.

In addition, I noticed an error while cleaning up bun install cache paths while testing bun install bun

To ensure this never happens again, changes to bun-release will trigger a CI action which verifies bun can install them.


when doing bun pm cache rm, it will display this note on windows when it fails

image image

@paperclover paperclover marked this pull request as draft April 3, 2024 04:53
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Copy link
Contributor

github-actions bot commented Apr 3, 2024

@paperdave 1 files with test failures on bun-darwin-aarch64:

View test output

#bb9f81dd869326ddb2433e1e648ed769a4431982

Copy link
Contributor

github-actions bot commented Apr 3, 2024

@paperdave 2 files with test failures on bun-darwin-x64:

View test output

#bb9f81dd869326ddb2433e1e648ed769a4431982

@paperclover paperclover marked this pull request as ready for review April 4, 2024 06:16
@paperclover paperclover merged commit 0cdad4b into main Apr 4, 2024
10 of 16 checks passed
@paperclover paperclover deleted the dave/win/npm-install branch April 4, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM-installed Bun does not work on windows
1 participant