Toogle Theme button accessible using keyboard and Enter press #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! I've tested it locally, and everything seems to be working fine. |
HammadYousaf01
approved these changes
Mar 19, 2025
ahmed-arb
requested changes
Mar 20, 2025
do you think we have to add change logs for each accessibility PR? there are more than 100 very small things are there TBD. |
|
That’s a fair point. We could bundle those changes together to minimize repeated reviews and testing overhead, and also reduce the number of changelog entries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Made Toggle Theme button keyboard accessible in top nav bar.
Ticket: https://tree.taiga.io/project/zaraahmed-tutor-indigo-accessibility/us/110