fix: bump indigo header and footer versions#143
Merged
HammadYousaf01 merged 2 commits intomainfrom Apr 25, 2025
Merged
Conversation
regisb
reviewed
Apr 24, 2025
|
|
||
| RUN npm install @edly-io/indigo-frontend-component-footer@^2.0.0 | ||
| RUN npm install '@edx/frontend-component-header@npm:@edly-io/indigo-frontend-component-header@^3.2.2' | ||
| RUN npm install @edly-io/indigo-frontend-component-footer@^3.0.0 |
Contributor
There was a problem hiding this comment.
Really looking forward to getting rid of these two lines... Can you please remind me why we need them?
| @@ -0,0 +1 @@ | |||
| - [Fix] Bump Indigo Header and Footer versions to fix images build fail for teak. (by @HammadYousaf01) | |||
Contributor
There was a problem hiding this comment.
- BugFix, not Fix
- The docker Image build is not failing for teak but rather upstream master (main branch).
HammadYousaf01
force-pushed
the
fix/bump-indigo-packages-versions
branch
from
f93992f to
839cfb6
Compare
DawoudSheraz
approved these changes
Apr 25, 2025
HammadYousaf01
force-pushed
the
fix/bump-indigo-packages-versions
branch
from
839cfb6 to
2eee48f
Compare
github-project-automation
Bot
moved this from In review
to Done
in Tutor project management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump Indigo header and footer versions to fix the Issue #142.
Steps to verify the fix:
fix/bump-indigo-packages-versionsbranch.masterbranch of any MFE and build {mfe}-dev image.The image should build without any issues while installing indigo-footer V3 and indigo-header V4.