-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: footer date #63
fix: footer date #63
Conversation
also, |
9d25c4d
to
33086f7
Compare
- openedx URL fixed - code block used for mako for a better code highlighting
I don't think this will fix the hard coded date on the MFE apps domain (and others?) |
I don't get it. Why not? |
At least from what I am seeing is the Apps MFE does not inherit settings from Indigo, though it uses parts of it (like links to the logos) such as the color or footer settings. Maybe it's something broken with my forked theme, but it is something to check. |
Yeah, 99% it comes from this https://github.com/edly-io/frontend-component-footer/blob/quince/indigo/src/components/Footer.messages.js#L159-L163 |
Thanks for the PR. Let me make sure, everything is working for merging. Also, It won't update the MFE footer year because it's hard-coded in MFE footer. |
You're right, @misilot. It won't fix the hardcoded year in the learner dashboard mfe. I didn't notice the new changes in Quince: |
@CodeWithEmad There is no documentation of new changes related to indigo-footer. Let me add this to my to-do list. |
@CodeWithEmad Thanks for the PR. Great Work! |
This will:
Close #62 #64