fix: Correcting patch file and making changes to make jupyter work in dev env #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,8 @@ | |||
| jupyterhub: | |||
There was a problem hiding this comment.
Hmmm, why is this needed now? How was it working before?
There was a problem hiding this comment.
@Abdul-Muqadim-Arbisoft following up on this. Plus, having the info in the PR description will be helpful as well
There was a problem hiding this comment.
Moving this PR to draft, since needs some more modifications, will add description as well , tutor Jupyter was never working before on dev but it was only working on local, due to wrong patch file there is no such path as dev-docker-compose-services
There was a problem hiding this comment.
I have completed the testing, and the description has been updated accordingly. The Tutor Jupyter plugin now functions correctly in both development and local modes.
DawoudSheraz
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues with the Tutor Jupyter plugin not functioning in development mode. Previously, the plugin lacked a necessary patch file for development environments. This update introduces a new patch file, openedx-development-settings, which ensures that the Jupyter plugin operates correctly in both development and local modes.
Additionally, this PR removes an incorrect reference to a non-existent patch file named dev-docker-compose-services. Confirmation that this patch file does not exist can be found in the official documentation here: Tutor Patches Reference.