Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: feat: add MEILISEARCH_STORAGE_SIZE configuration #1196

Conversation

viadanna
Copy link
Contributor

@viadanna viadanna commented Feb 6, 2025

Description

This PR makes it possible to configure MeiliSearch storage size.

Testing instructions

  1. Create a new Tutor instance.
  2. Modify the config.yml file, adding:
MEILISEARCH_STORAGE_SIZE: 1Gi
  1. Run tutor k8s launch to deploy the new instance.
  2. Confirm the deployment is successful.
  3. Confirm the Meilisearch PVC new size:
$ kubectl -nsumac get pvc/meilisearch
NAME          STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   VOLUMEATTRIBUTESCLASS   AGE
meilisearch   Bound    pvc-6500a7bd--ee9211966da0   1Gi        RWO            gp2            <unset>                 20m

@viadanna viadanna marked this pull request as draft February 6, 2025 17:58
Copy link
Contributor

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@regisb
Copy link
Contributor

regisb commented Feb 10, 2025

We are trying as much as we can to limit the number of Tutor configuration settings. In particular, we don't want to turn every hard-coded k8s value into a setting. Instead, operators should customise their environment using plugins. In this particular case, you should use the "k8s-override" patch.

For similar conversations, please look at:
#675
#677

@viadanna viadanna closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Won't fix
Development

Successfully merging this pull request may close these issues.

3 participants