Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flowAppCpp #40

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Fix flowAppCpp #40

merged 2 commits into from
Aug 17, 2023

Conversation

JulianGro
Copy link
Member

@JulianGro JulianGro commented Aug 3, 2023

This PR updates flowAppCpp to use local entities instead of the removed 3d overlays.

There are three bugs that I haven't been able to fix (though I don't think they are new):

  • Switching avatars while having the debug view open doesn't remove the old debug entities.
  • Flow “chains” that are just a single bone instead of a proper chain, will draw a line to 0,0,0 coordinates. On line 470 it goes up the flow chain, but because there is only one bone it hits undefined behaviour. I am just not good enough at JavaScript right now to figure out how to properly check against that.
  • The joint selection dropdown in the collisions tab doesn't work. The joints are in there, as selecting the box, moving with the arrow keys, and pressing enter, changes the selected joint. The dropdown itself just doesn't seem to appear.

@JulianGro JulianGro added the needs CR This pull request needs to be code reviewed label Aug 3, 2023
@Colorfingers
Copy link
Contributor

Code looks good to me... no breaking changes from what I can tell...

Copy link
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine :)

@ksuprynowicz ksuprynowicz merged commit dbe889c into master Aug 17, 2023
1 check passed
@JulianGro JulianGro deleted the update_flowApp branch August 19, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs CR This pull request needs to be code reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants