Change standard automatic networking setting #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a really good idea. Previous default setting was causing trouble. |
ksuprynowicz
approved these changes
Jul 29, 2022
|
Here are some builds you may use for testing: macOS-10.15, full ubuntu-18.04, full
self-hosted_debian-11_aarch64, full
windows-2019, full |
ksuprynowicz
added
needs QA
|
Works perfectly on Windows. I think it's ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting "None" causes issues when registering a place on the Metaverse server. See overte-org/metaverse-dashboard#4
I would also argue that the standard setting should be the one that has the best chance of actually working.