Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Initial verison of the script editor #621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

keeshii
Copy link
Contributor

@keeshii keeshii commented Sep 13, 2023

This is implementation of the script editor integrated with the create app. This pull-request adds button next to "refresh-script", that opens a code editor in an overlay window. From there there is a possibility to spawn a web-entity for collaborative work.

This editor is still work in progress. Waiting for the changes in the CPP side.

@JulianGro
Copy link
Member

I tried making CMake download the script editor assets as part of the build process, so we don't have all of these pre-compiled files in our main repository. See the patch (I also deleted the relevant assets in the interface/resources). I ran into an issue though, where Interface wouldn't load the file (in my case file:///~/html/script-editor/index.html). Other files in uncompressed resources like file:///~/serverless/tutorial.json can be loaded fine and I don't see any typo in the path.

I am just posting this here, so it doesn't get lost. In the patch I am loading from resources that weren't patched into the qrc; This is because we package the qrc directly from the source at configuration time, while the ExternalProject mechanism gets the assets at build time. To circumvent this, we could create a Python script that downloads the assets at configuration time, and then either put the assets into .gitignore or create the qrc from the build directory instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants