Add centos8 builder #42
Conversation
I came across this while working on overviewer#42 but it seemed like its own problem, worthy of its own PR. 9 days ago, [werkzeug was updated](https://github.com/pallets/werkzeug/releases/tag/1.0.0) The changelog contains this: > Remove most top-level attributes provided by the werkzeug module in favor of direct imports. For example, instead of import werkzeug; werkzeug.url_quote, do from werkzeug.urls import url_quote. Install version 0.16 first to see deprecation warnings while upgrading. #2, #1640 So I updated the components that import from werkzeug to versions that have the imports fixed.
|
Still working on this per your suggestions @CounterPillow but I ran into an unrelated problem today when I rebuilt the docker containers without cache. Submitted PR for it: #43 |
|
@CounterPillow ready for re-review whenever you can |
|
All of this is going a bit over my head, but does this mean there will be official Centos8 support coming and if so should I wait for that? Alternatively is this a method I could duplicate on my current server? |
|
@g2bb overviewer is already compatible with centos8 if you build from source, this just adds an automated rpm builder for it. If you are comfortable using docker, you can use this branch to get an rpm built for you, but that is probably overkill. To be clear, I am not a member of the overviewer team, just the author of this PR. I don't know when or if it will be merged. |
|
Following the tutorial on the website to install it on my Centos 8 server nets me when I type After a little more digging I found that http://overviewer.org/rpms/8/x86_64/repodata/repomd.xml does not exist which is why it can't find the repo metadata. Infact there is no /rpms/8/* folder at all. There is /rpms/7/* but as I understand it, Centos 8 is looking for one at /8/. Maybe what I'm saying here is all wrong and if it is please correct me, but I don't know what to do to fix this issue. |
|
@g2bb
|
ref: overviewer/Minecraft-Overviewer#1677
I was able to trigger a manual build within buildbot and it appeared to build successfully. It failed on the signing step with the error "gpg: signing failed: Inappropriate ioctl for device" which I think is gpg wanting to do something with the tty and not having one or not finding the correct tty for some reason. I'm guessing this is related to my environment because it fails for a manual build with the centos7 builder the same way.
I did NOT test the resulting RPM from this build and therefore I purposely did not update flask/overviewer/downloads.py so that way you can merge this if desired and then see if the resulting properly signed RPMs work before publishing a link on the website.