Skip to content

feat(legacy-tools): adding iceberg response handler #19815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

feat(legacy-tools): adding iceberg response handler #19815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/manager-tools/manager-legacy-tools/test-utils/src/types/handler.type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
export type Handler<T = any> = {
url: string;
response?: T;
icebergResponse?: T;
headers?: HeadersInit;
statusText?: string;
type?: ResponseType;
Expand Down
20 changes: 15 additions & 5 deletions packages/manager-tools/manager-legacy-tools/test-utils/src/utils/common-validators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
import { screen, waitFor, waitForOptions } from '@testing-library/react';
import {
Matcher,
SelectorMatcherOptions,
screen,
waitFor,
waitForOptions as WaitForOptions,
} from '@testing-library/react';
import { WAIT_FOR_DEFAULT_OPTIONS } from './common.constants';

export const assertTextVisibility = async (text: string): Promise<void> =>
export const assertTextVisibility = async (
text: Matcher,
options?: SelectorMatcherOptions,
waitForOptions = WAIT_FOR_DEFAULT_OPTIONS,
): Promise<void> =>
waitFor(
() => expect(screen.getByText(text)).toBeVisible(),
WAIT_FOR_DEFAULT_OPTIONS,
() => expect(screen.getByText(text, options)).toBeVisible(),
waitForOptions,
);

export const assertElementVisibility = (
Expand All @@ -19,7 +29,7 @@ export const assertElementLabel = ({
}: {
element: HTMLElement;
label: string;
} & waitForOptions): Promise<void> =>
} & WaitForOptions): Promise<void> =>
waitFor(() => expect(element).toHaveAttribute('label', label), {
...WAIT_FOR_DEFAULT_OPTIONS,
...options,
Expand Down
23 changes: 19 additions & 4 deletions packages/manager-tools/manager-legacy-tools/test-utils/src/utils/msw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export const toMswHandlers = (handlers: Handler[] = []): RequestHandler[] =>
delay: delayTime = 1000,
status = 200,
response,
icebergResponse,
responseText,
api = 'v6',
baseUrl,
Expand All @@ -30,10 +31,24 @@ export const toMswHandlers = (handlers: Handler[] = []): RequestHandler[] =>
if (responseText) {
return HttpResponse.text(responseText);
}
const json =
typeof response === 'function'
? await response(request, params, cookies)
: response;
const requestHeaders = new Headers(request?.headers);
const isIceberg =
requestHeaders.get('X-Pagination-Size') ||
requestHeaders.get('x-pagination-mode');

let json;
if (isIceberg && icebergResponse) {
json =
typeof icebergResponse === 'function'
? await icebergResponse(request, params, cookies)
: icebergResponse;
} else {
json =
typeof response === 'function'
? await response(request, params, cookies)
: response;
}

return HttpResponse.json(json, {
status,
headers,
Expand Down
Loading