Skip to content

Conversation

@atefzed
Copy link
Contributor

@atefzed atefzed commented Oct 17, 2025

ref: #PRDCOL-219

Description

Ticket Reference: #PRDCOL-219

Additional Information

Capture d’écran 2025-10-17 à 16 57 52

@atefzed atefzed requested a review from a team as a code owner October 17, 2025 14:58
@atefzed atefzed requested a review from ghyenne October 17, 2025 14:58
@atefzed atefzed requested a review from a team as a code owner October 17, 2025 15:03
@atefzed atefzed force-pushed the feat/PRDCOL-219 branch 2 times, most recently from 9edd644 to 8967900 Compare October 20, 2025 09:07
"zimbra_account_delete_modal_content_step2": "Êtes-vous vraiment sûr(e) de vouloir supprimer ce compte email <strong>{{ email }}</strong> ?",
"zimbra_account_delete_all_modal_content_step1": "Êtes-vous sûr(e) de vouloir supprimer les comptes suivants ? <br/><strong>{{ emails }}</strong>",
"zimbra_account_delete_all_modal_content_step2": "Êtes-vous vraiment sûr(e) de vouloir supprimer ces comptes email suivants ? <br/><strong>{{ emails }}</strong>",
"zimbra_account_delete_all_confirm_label": "Saisissez <strong>{{ label }}</strong> pour confirmer la suppression: ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"zimbra_account_delete_all_confirm_label": "Saisissez <strong>{{ label }}</strong> pour confirmer la suppression: ",
"zimbra_account_delete_all_confirm_label": "Saisissez <strong>{{ label }}</strong> pour confirmer la suppression :",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines 23 to 24
"zimbra_account_delete_all_modal_content_step1": "Êtes-vous sûr(e) de vouloir supprimer les comptes suivants ? <br/><strong>{{ emails }}</strong>",
"zimbra_account_delete_all_modal_content_step2": "Êtes-vous vraiment sûr(e) de vouloir supprimer ces comptes email suivants ? <br/><strong>{{ emails }}</strong>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"zimbra_account_delete_all_modal_content_step1": "Êtes-vous sûr(e) de vouloir supprimer les comptes suivants ? <br/><strong>{{ emails }}</strong>",
"zimbra_account_delete_all_modal_content_step2": "Êtes-vous vraiment sûr(e) de vouloir supprimer ces comptes email suivants ? <br/><strong>{{ emails }}</strong>",
"zimbra_account_delete_all_modal_content_step1": "Êtes-vous sûr(e) de vouloir supprimer les comptes suivants ?",
"zimbra_account_delete_all_modal_content_step2": "Êtes-vous vraiment sûr(e) de vouloir supprimer ces comptes email suivants ?",

I think no need to put the mail directly in translation, we can do it in code directly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@atefzed atefzed force-pushed the feat/PRDCOL-219 branch 2 times, most recently from 1669828 to 2698990 Compare October 20, 2025 14:32
@atefzed atefzed requested a review from ghyenne October 20, 2025 14:33
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature has conflicts Has conflicts to resolve before merging translation required universe-web-cloud

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants