fix(pci-block-storage): add file storage alpha information banner #19828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aTurmo
requested review from
Tsiorifamonjena,
fredericvilcot,
lionel95200x,
lolottetheclash,
manoncarbonnel and
ppprevost
github-actions
bot
added
translation required
universe-public-cloud
feature
aTurmo
force-pushed
the
feat/TAPC-5227_file_storage_banner
branch
from
abc6ce3 to
3176dc1
Compare
lolottetheclash
requested changes
Oct 20, 2025
There was a problem hiding this comment.
This is nice to communalize the banner logic, well done 👍
I'm just wondering if it coud be a good idea to have some kind of standard banner already implemented into the Banner, which will allow to just pass some properties (and will lighten the addBanner call)?
by the way, could you update your commit as there is a spelling error ?
packages/manager/apps/pci-block-storage/src/components/button-link/ButtonLink.tsx
Outdated
Show resolved
Hide resolved
...es/manager/apps/pci-block-storage/src/components/banner/FileStorageAlphaBanner.component.tsx
Show resolved
Hide resolved
packages/manager/apps/pci-block-storage/src/contexts/GeneralBanner.context.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-block-storage/src/contexts/GeneralBanner.context.tsx
Show resolved
Hide resolved
aTurmo
changed the title
aTurmo
force-pushed
the
feat/TAPC-5227_file_storage_banner
branch
from
3176dc1 to
a8992c9
Compare
Tsiorifamonjena
previously approved these changes
Oct 27, 2025
lolottetheclash
previously approved these changes
Oct 27, 2025
aTurmo
dismissed stale reviews from lolottetheclash and Tsiorifamonjena
via
dd81f97
aTurmo
force-pushed
the
feat/TAPC-5227_file_storage_banner
branch
from
a8992c9 to
dd81f97
Compare
aTurmo
force-pushed
the
feat/TAPC-5227_file_storage_banner
branch
from
dd81f97 to
2c3c018
Compare
aTurmo
requested review from
pauldkn and
sefiani-ovh
and removed request for
a team
aTurmo
force-pushed
the
feat/TAPC-5227_file_storage_banner
branch
from
2c3c018 to
2e95628
Compare
lolottetheclash
approved these changes
Oct 30, 2025
Tsiorifamonjena
approved these changes
Oct 30, 2025
ref: #TAPC-5227 Signed-off-by: Adrien Turmo <[email protected]> Co-authored-by: CDS Translator Agent <[email protected]>
ref: #TAPC-5227 Signed-off-by: Adrien Turmo <[email protected]>
aTurmo
force-pushed
the
feat/TAPC-5227_file_storage_banner
branch
from
2e95628 to
5df9d2e
Compare
aTurmo
commented
Oct 30, 2025
Comment on lines
+40
to
62
| const shellContextValue: RecursivePartial<ShellContextType> = { | ||
| shell: { | ||
| navigation: { | ||
| getURL: (_, path) => Promise.resolve(`https://ovh.test/#${path}`), | ||
| }, | ||
| ux: { | ||
| hidePreloader: () => Promise.resolve(), | ||
| }, | ||
| tracking: { | ||
| trackClick: () => {}, | ||
| }, | ||
| }, | ||
| environment: { | ||
| getUser: () => ({ ovhSubsidiary: 'mocked_ovhSubsidiary' }), | ||
| getRegion: () => 'EU', | ||
| }, | ||
| }; | ||
|
|
||
| const wrapper = ({ children }) => ( | ||
| <QueryClientProvider client={queryClient}>{children}</QueryClientProvider> | ||
| <ShellContext.Provider value={shellContextValue as ShellContextType}> | ||
| <QueryClientProvider client={queryClient}>{children}</QueryClientProvider> | ||
| </ShellContext.Provider> | ||
| ); |
There was a problem hiding this comment.
this is to fix the test after react-shell-client version bump
This was referenced Oct 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #TAPC-5227