feat(pci-worklow): Refactoring workflow to improve genericity #20504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: #TAPC-5306 Signed-off-by: Adrien Turmo <[email protected]>
ref: #TAPC-5306 Signed-off-by: Adrien Turmo <[email protected]>
aTurmo
requested review from
Taelar,
Tsiorifamonjena,
aboungnaseng-ovhcloud,
anooparveti,
fredericvilcot,
helabenkhalfallah,
lionel95200x,
lolottetheclash and
ppprevost
and removed request for
a team
aTurmo
changed the base branch from
feat/TAPC-4416_distant_backup_lot_2_light
to
epic/TAPC-4378_automatic_volume_backup
ref: #TAPC-5306 Signed-off-by: Adrien Turmo <[email protected]>
… and not an instance ref: #TAPC-5306 Signed-off-by: Adrien Turmo <[email protected]>
ref: #TAPC-5306 Signed-off-by: Adrien Turmo <[email protected]>
ref: #TAPC-5306 Signed-off-by: Adrien Turmo <[email protected]>
ref: #TAPC-5306 Signed-off-by: Adrien Turmo <[email protected]>
aTurmo
force-pushed
the
feat/TAPC-5306_refactoring_workflow
branch
from
8e2956f to
5fb8077
Compare
ppprevost
reviewed
Nov 19, 2025
| if (enabled) { | ||
| return useInstanceSnapshotPricing; | ||
| } | ||
| return () => ({}) as ReturnType<typeof useInstanceSnapshotPricing>; |
Contributor
There was a problem hiding this comment.
question: why a void function ?
| export const isSameResource = (a: TWorkflowResourceId, b: TWorkflowResourceId): boolean => | ||
| a.id === b.id && a.region === b.region; | ||
|
|
||
| export const getResourcePricing = ( |
Contributor
There was a problem hiding this comment.
issue: it is a hook because you call a useInstanceSnapshotPricing which is a hook
| type WorkflowKeys = keyof Omit<TWorkflow, 'executions'>; | ||
| type WorkflowKeys = keyof Omit<TInstanceBackupWorkflow, 'executions'>; | ||
| const keys: WorkflowKeys[] = ['name', 'instanceName', 'cron']; | ||
| return data.filter((workflow) => |
Contributor
There was a problem hiding this comment.
this functions is doing a lot of things, and lean on a mutation on data
Maybe you could cut this function into differnet part sort and filter
Contributor
Author
There was a problem hiding this comment.
I did something tell me if it's better
Tsiorifamonjena
approved these changes
Nov 20, 2025
ref: #TAPC-5306 Signed-off-by: Adrien Turmo <[email protected]>
Tsiorifamonjena
approved these changes
Nov 21, 2025
ref: #TAPC-5306 Signed-off-by: Adrien Turmo <[email protected]>
ppprevost
reviewed
Nov 21, 2025
| const { id: sortKey, desc } = sorting; | ||
|
|
||
| data.sort(defaultCompareFunction(sortKey as keyof Omit<TWorkflow, 'executions'>)); | ||
| data.sort(defaultCompareFunction(sortKey as WorkflowKeys)); |
Contributor
There was a problem hiding this comment.
it appears that sort has a side effect on data. Maybe you could encapsulate it into a function and then call it before filtering your data
const applySort = (workflow)=> {
const data = [...workflow].sort(defaultCompareFunction(sortKey as WorkflowKeys)
return desc ? data.reverse() : data
}
-->
const data = applySort(workflow)
return data.filter(...)
```
ref: #TAPC-5344 Signed-off-by: Adrien Turmo <[email protected]>
ppprevost
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #TAPC-5306
Currently the application is too much linked specifically to automatic instance backup and the aim is to break this in order to be able to more easily add another workflow.
This is done in preparation to the new automatic volume backup workflow.
This PR is separated in thematic commits.