fix(muk): correct hook useTranslatedMicroRegion #20518
Open
+126
−303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: #MANAGER-20207 Signed-off-by: Alex Boungnaseng <[email protected]>
ref: #MANAGER-20207 Signed-off-by: Alex Boungnaseng <[email protected]>
aboungnaseng-ovhcloud
requested review from
anooparveti and
helabenkhalfallah
anooparveti
reviewed
Nov 20, 2025
Comment on lines
+3
to
+24
| import { NAMESPACES } from '@ovh-ux/manager-common-translations'; | ||
|
|
||
| import regionFrFR from '@ovh-ux/manager-common-translations/public/translations/region/Messages_fr_FR.json'; | ||
| import regionEnGB from '@ovh-ux/manager-common-translations/public/translations/region/Messages_en_GB.json'; | ||
| import regionDeDE from '@ovh-ux/manager-common-translations/public/translations/region/Messages_de_DE.json'; | ||
| import regionEsES from '@ovh-ux/manager-common-translations/public/translations/region/Messages_es_ES.json'; | ||
| import regionItIT from '@ovh-ux/manager-common-translations/public/translations/region/Messages_it_IT.json'; | ||
| import regionPtPT from '@ovh-ux/manager-common-translations/public/translations/region/Messages_pt_PT.json'; | ||
| import regionPlPL from '@ovh-ux/manager-common-translations/public/translations/region/Messages_pl_PL.json'; | ||
| import regionFrCA from '@ovh-ux/manager-common-translations/public/translations/region/Messages_fr_CA.json'; | ||
|
|
||
| function addRegionTranslations() { | ||
| i18n | ||
| .addResources('fr_FR', NAMESPACES.REGION, regionFrFR) | ||
| .addResources('en_GB', NAMESPACES.REGION, regionEnGB) | ||
| .addResources('de_DE', NAMESPACES.REGION, regionDeDE) | ||
| .addResources('es_ES', NAMESPACES.REGION, regionEsES) | ||
| .addResources('it_IT', NAMESPACES.REGION, regionItIT) | ||
| .addResources('pt_PT', NAMESPACES.REGION, regionPtPT) | ||
| .addResources('pl_PL', NAMESPACES.REGION, regionPlPL) | ||
| .addResources('fr_CA', NAMESPACES.REGION, regionFrCA); | ||
| } |
Contributor
There was a problem hiding this comment.
question: Do we need to import and add all the translations that we use in MUK?
Contributor
Author
There was a problem hiding this comment.
That how I resolve it in the storybook, But I have test it in generated app, we dont need to import it in this way
helabenkhalfallah
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket Reference: #MANAGER-20207
Additional Information