Skip to content

Conversation

@Taelar
Copy link

@Taelar Taelar commented Nov 21, 2025

ref: #TAPC-5335

Description

Ticket Reference: #...

Additional Information

@Taelar Taelar requested a review from a team as a code owner November 21, 2025 14:03
@github-actions github-actions bot added universe-public-cloud build Changes that affect the build system or external dependencie labels Nov 21, 2025
@Taelar Taelar force-pushed the build/TAPC-5335-pci-block-storage-vitest branch from e221d96 to 354b9c8 Compare November 21, 2025 15:01
@github-actions github-actions bot added build Changes that affect the build system or external dependencie and removed build Changes that affect the build system or external dependencie labels Nov 21, 2025
@fredericvilcot
Copy link
Contributor

@Taelar
You are targeting an epic branch or develop branch?

@Taelar
Copy link
Author

Taelar commented Nov 21, 2025

@Taelar You are targeting an epic branch or develop branch?

In the end I will target develop but for now I target the pnpm branch as I need the changes from the pnpm commit but I don't want these to appear here since they are part of #20513 . Once I get to merge the pnpm migration, I can target this PR to develop

aTurmo
aTurmo previously approved these changes Nov 21, 2025
Copy link
Contributor

@aTurmo aTurmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Base automatically changed from build/block-storage-pnpm-migrate to develop November 24, 2025 08:44
@Taelar Taelar dismissed stale reviews from Tsiorifamonjena and aTurmo November 24, 2025 08:44

The base branch was changed.

ref: #TAPC-5335

Signed-off-by: Thomas Esseul <[email protected]>
@Taelar Taelar force-pushed the build/TAPC-5335-pci-block-storage-vitest branch from 354b9c8 to ae90ee1 Compare November 24, 2025 09:04
@github-actions github-actions bot added build Changes that affect the build system or external dependencie and removed build Changes that affect the build system or external dependencie labels Nov 24, 2025
Copy link
Contributor

@lolottetheclash lolottetheclash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Taelar Taelar merged commit 3cf2231 into develop Nov 24, 2025
16 checks passed
@Taelar Taelar deleted the build/TAPC-5335-pci-block-storage-vitest branch November 24, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Changes that affect the build system or external dependencie universe-public-cloud

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants