Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix gpumetrics sampler #1279

Closed
wants to merge 1 commit into from
Closed

Conversation

nichamon
Copy link
Collaborator

@nichamon nichamon commented Sep 5, 2023

No description provided.

@tom95858
Copy link
Collaborator

tom95858 commented Oct 9, 2023

Hi @nichamon, what is the status of this change.

@tom95858
Copy link
Collaborator

@nichamon what is that status of this pull request?

@nichamon
Copy link
Collaborator Author

@nichamon what is that status of this pull request?

Intel had problems building it. I asked them to check their Makefile.am if it contains a typo or not. I'm waiting for their response.

However, the patch does not fix the GPU sampler's inconsistency state problem reported here . I made a patch to build the plugin on Ubuntu and fix the missing -lovis_log in the Makefile.am.

We first suspected that the ovis_log patch caused the GPU set to get stuck in an inconsistent state. I don't have the GPU cards to create and sample the metrics properly. However, with the patch and some debugging code, I can load and run the plugin on my system. The debugging code was to bypass the check if the devices/cards were present on my machine or not.

According to the issue, they can load and run the plugin, so it is unlikely that the inconsistency was caused by the patch refactoring the plugin to use the ovis_log library.

@nichamon
Copy link
Collaborator Author

I'm closing this because it doesn't fix the problem reported in #1273.

@nichamon nichamon closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants