Make json_stream_sampler handle UID, GID, and perm #1281
Conversation
|
@tom95858 Do you think the plugin should revise the sets' UID, GID, or perm according to the stream data's security changes? The patch does not do that. It only makes sense when the UID, GID, or perm are from the received stream data at the set creation time. It could be confusing when the UID, GID, or perm values are specified at the config line. |
|
I'll mark this as ready when I have the test coverage done, and the patch passes the test cases. |
|
@narategithub I use the UID, GID, and perm in the |
|
@nichamon I think it makes sense for most cases. The corner case I can think of right now is stream data sending via root's channel (uid0, gid0), but somehow we want to create a set owned by a user (e.g. |
In this case, admins can specify the UID, GID, and perm at the config line of the plugin. The given values take precedent over the values in the stream data. |
We're running root-owned app data collection about linux processes, and part of that data is the uid/gid of each process. At the store, admins may use storage policies or set mappings with these uid/gid in setting up databases, but these uid/gid should not be confused with the ownership/group of the stream (who originally published it). |
nichamon
force-pushed
the
job_stream_sampler
branch
4 times, most recently
from
051640c
to
98658dd
Compare
Without the patch, the json_stream_sampler ignores the UID, GID, and perm given at the config line. With the patch, the plugin creates LDMS sets with the specified UID, GID, and permission. If one of the values are not given, it will use the security data from the received stream data. After the set has been created, the configuration command set_sec_mod must be used to modify the sets' security (UID, GID, and perm). The plugin does not automatically revise the set security according to the stream data's security changes.
nichamon
force-pushed
the
job_stream_sampler
branch
from
98658dd
to
70d1236
Compare
The plugin automatically generates the set instance name if none is given. The generated name is <producer>_<schema name>.
Add metric types to the LDMS sets' JSON objects
nichamon
force-pushed
the
job_stream_sampler
branch
from
70d1236
to
54c7f47
Compare
nichamon
changed the title
|
The patch passes against the test coverage here. |
|
I'm closing this to prevent Github from running the build test and sending emails to people. I'll create another pull request when the patches are ready. |
Without the patch, the json_stream_sampler receives the UID, GID, and perm values at the config line, but it does not apply the values to the metric sets.
The patch makes the plugin use the specified UID, GID, and permission; otherwise, it will use the security data from the received stream data. The security data is applied at the set creation time. The configuration command set_sec_mod must be used to modify the sets' security. The plugin does not automatically revise the set security according to the stream data's security changes.