Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert rx_rate parameter argument to string in prdcr_subscribe #1283

Merged
merged 1 commit into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ldms/python/ldmsd/ldmsd_communicator.py
Original file line number Diff line number Diff line change
Expand Up @@ -2201,7 +2201,7 @@ def prdcr_stop(self, name, regex=True):
self.close()
return errno.ENOTCONN, str(e)

def prdcr_subscribe(self, regex, stream, rx_rate=-1):
def prdcr_subscribe(self, regex, stream, rx_rate='-1'):
"""
Subscribe to stream data from matching producers

Expand All @@ -2219,7 +2219,7 @@ def prdcr_subscribe(self, regex, stream, rx_rate=-1):
attrs = [
LDMSD_Req_Attr(attr_id=LDMSD_Req_Attr.REGEX, value=regex),
LDMSD_Req_Attr(attr_id=LDMSD_Req_Attr.STREAM, value=stream),
LDMSD_Req_Attr(attr_id=LDMSD_Req_Attr.RX_RATE, value=rx_rate)
LDMSD_Req_Attr(attr_id=LDMSD_Req_Attr.RX_RATE, value=str(int(rx_rate)))
])
try:
req.send(self)
Expand Down
2 changes: 1 addition & 1 deletion ldms/python/ldmsd/ldmsd_controller
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ class LdmsdCmdParser(cmd.Cmd):
interval= The connection retry interval (us) (Deprecated, please use 'reconnect'.)
auth= The authentication method
[perm=] The permission to modify the producer in the future.
[rail=] The number of rail endpooints for the prdcr (default: 1).
[rail=] The number of rail endpoints for the prdcr (default: 1).
[credits=] The send credits our ldmsd (the one we are controlling)
advertises to the prdcr (default: value from ldmsd --credits
option). This limits how much outstanding data our ldmsd
Expand Down