Add C and Python API for LDMS Schema info access #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BYTES()` converted `str`, or `object` into `bytes` which can later converted to `char *` by Cython. However, `BYTES(None)` got converted to `b'None'`, which is unintended. What we wanted in `ldms.pyx` is to convert `None` as NULL. In order to do so, we need `CSTR()` to convert `bytes` or `None` into `char *` or `NULL` respectively. We cannot convert `object` into `char *` or `NULL` in one go in `CSTR` because the first `bytes` conversion would be an object that temporarily lives in the `CSTR()` function and the `<char*>` conversion on that temporary object will be an invalid pointer. This patch also add `CBYTES(c_str)` that returns `None` when `c_str` is `NULL`. We need this because `char *` is automatically converted to `bytes` automatically by Cython when it is assigned to a Python variable, but the program crashes when the pointer is NULL (due to the subsequent invalid `PyBytes_FromString(NULL)` call).
…emplate()` For `LDMS_V_RECORD_TYPE`, `rec_def->flags` is used and the `ent->flags` is actually ignored. Hence, we should not check `ent->flags` and yeild an error because of it.
This is to support information access to LDMS Schema and Record Definition objects without the LDMS sets. The schema registry needs these APIs to access metric information inside the Schema and Record Definition to construct their representation in the Schema Registry database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support information access to LDMS Schema and Record
Definition objects without the LDMS sets. The schema registry needs
these APIs to access metric information inside the Schema and Record
Definition to construct their representation in the Schema Registry
database.
This pull request also includes bug fixes found along the way.