[b4.4] Fix "fill" handling in static decomposition #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 5, 2024 09:24
If "fill" was correctly specified, `cfg_col->fill` will have a value. Otherwise, `cfg-col->fill` will be `NULL`. We should use `cfg_col->fill` to determine if "fill" was present.
The "fill" string value was handled incorrectly. This patch fixes the bug.
narategithub
changed the title
|
Still broken, but in a different way: Error message isn't terribly helpful. I am not sure what it isn't liking. |
|
@morrone can I see your config? |
|
@morrone never mind me. It was an incorrect assertion that |
added 2 commits
November 7, 2024 21:04
- Adress the issue that the static decomposition incorrectly set `LDMS_V_LIST` as type of the column when "type" was not specified in the config. - In the case of multiple lists with different length in a set, the number of produced rows equals to the number of the longest list. When the shorter lists are exhausted, the "fill" value of the respective column is used. However, if "fill" was not specified, `ldmsd` crashed due to `NULL` fill mval. This patch uses a `zfill` (zero value) as a fall back if "fill" was not specified.
|
@morrone Could you please give this another whirl? |
|
@narategithub It looks like there are no longer any errors thrown with my config and your latest fix. My testbed is slightly broken (networking issues) at the moment, so I can't quite check the full decomposition output for correctness. But I can see that my "cluster" default fill is at least working, so that is a good sign. |
morrone
approved these changes
Nov 9, 2024
|
Thank you, @morrone ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed #1495 . This PR (with #1498 and #1499) has been tested with these test cases in
ldms-testrepo (branchb4.4):