LDMS Rail fixes #1430
LDMS Rail fixes #1430
Conversation
The application should only interacts with the rail object. However, the legacy connection from the remote peer slipped through and got exposed to the application. This patch wraps the legacy connection xprt inside a rail object.
|
@nick-enoent I tested this but could you please include this in your test? |
Sure thing, I'll give it a go today. |
|
@narategithub I haven't found any issue with the rails fixes you implemented. |
ldms/src/core/ldms_rail.c
Outdated
| * Tell the peer that have an RBD for this set that it is being | ||
| * deleted. When they all reply, we can delete the set. | ||
| */ | ||
| void __rail_set_delete(ldms_t _r, struct ldms_set *s, |
There was a problem hiding this comment.
It would be great if the function name format differs from the rails operation interfaces, e.g., __rail_listen().
There was a problem hiding this comment.
any suggestion? the '__' was just meant to mark private, in a sense that application should not call it (it is not exported in ldms.h ...).
There was a problem hiding this comment.
I agree with you that __rail_on_set_delete helps at least to me to know that it's that an operation.
narategithub
force-pushed
the
rail-fix
branch
2 times, most recently
from
8200bcc
to
5bfc435
Compare
ldms/src/core/ldms_rail.c
Outdated
| } else { | ||
| /* | ||
| * This condition is only for `x` with legacy LDMS remote peer. | ||
| * I this case, we shall wrap `x` with a new rail before |
There was a problem hiding this comment.
A typo: 'I' should read 'In'.
There was a problem hiding this comment.
oops. thanks.
ldms/src/core/ldms_rail.c
Outdated
| * Tell the peer that have an RBD for this set that it is being | ||
| * deleted. When they all reply, we can delete the set. | ||
| */ | ||
| void __rail_set_delete(ldms_t _r, struct ldms_set *s, |
There was a problem hiding this comment.
I agree with you that __rail_on_set_delete helps at least to me to know that it's that an operation.
This pull request addresses the following issues:
set_by_name()xprt operation.set_deletenotification code path to support rail.