Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recovery context after internal redirect, re-add #273 #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

airween
Copy link
Member

@airween airween commented Feb 19, 2025

This PR is a "copy" of #273, plus I added some tests to check the behavior that the patch adds.

Original credits to @liudongmiao.

@liudongmiao could you take a review?

@liudongmiao
Copy link

@airween what's the difference with #334?

@airween
Copy link
Member Author

airween commented Feb 20, 2025

@airween what's the difference with #334?

Nothing. As I explained in my initial comment, this is a copy of #344.

But if you take a look at the history, I had to revert last two PR's. Then I added few additional tests, and now I would like to re-add your fix again.

So I hope it's a copy of #344 :), this is what would be a help to review.

@liudongmiao
Copy link

@airween It seems almost same.

However, I'd suggest you check whether it solves #182, #255, #258 like original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants