Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "network NBT" #109

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

occanowey
Copy link
Contributor

This adds support for post 1.20.2 networked NBT which doesn't encode compound tag names.
Pretty basic changes just adds a new deserialize option and a single if statement.

closes #103

@owengage
Copy link
Owner

owengage commented Apr 9, 2024

Excellent, thank you. You've managed to name everything as I would!

I'll merge this but will likely add some unit testing prior to releasing, unless you fancy adding those.

One important characteristic is only the root compound has its name skipped, I believe?

@owengage owengage merged commit 2709cbe into owengage:master Apr 9, 2024
1 check passed
@occanowey
Copy link
Contributor Author

Unless there's some specific packet doing something quirky then that's what it says on the wiki and I had a look at a vanilla servers registry data and it was only the root missing a name.

I'll add a test or two and open another pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] New protocol support
2 participants