-
Notifications
You must be signed in to change notification settings - Fork 6
feat: release bum for npm package 🎉 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace native-tls with rustls-tls in reqwest (pure Rust, no OpenSSL) - Disable libz-ng-sys by using deflate feature only in zip crate - Remove vendored OpenSSL dependencies (no longer needed) - Simplify CI: remove apk packages that were only for OpenSSL/libz-ng This fixes all Linux cross-compilation issues: - aarch64-unknown-linux-gnu: no more libz-ng-sys cmake failures - x86_64-unknown-linux-musl: no more crtbeginS.o/lgcc errors - aarch64-unknown-linux-musl: no more OpenSSL cross-compile issues
030ba9a to
a2318f9
Compare
Changes: - Download artifacts to 'artifacts/' dir instead of root - Move artifacts to root before universal build - Remove unnecessary file verification (napi universal will fail if files missing) - Update Node version from 18 to 22 - Simplify output messages This approach is cleaner and avoids hash collision issues.
The artifacts directory contains both hashed and non-hashed files. Remove hashed files (bum.darwin-*-*.node) to ensure napi universal only sees the clean files (bum.darwin-x64.node, bum.darwin-arm64.node).
Explicitly tell napi universal to look for binaries in current directory with the -d . flag to ensure it finds the files correctly.
The napi artifacts command fails when it finds hashed files. Remove all hashed .node files (pattern: *-*-*.node) before moving artifacts to npm packages. This ensures only clean files (bum.darwin-x64.node, etc.) are packaged.
Changes: - Remove tags-ignore to allow version tags to trigger CI - Add explicit tags pattern: v[0-9]+.[0-9]+.[0-9]+ - Add pull_request trigger for PR testing Now both deploy.yml and ci.yml trigger on version tags.
This release adds npm support via NAPI-RS: - Can now install via: npm install -g @owenizedd/bum - Supports npx usage: npx @owenizedd/bum use 1.3.0 - Multi-platform binaries published to npm - Original install.sh still works via GitHub Releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make bum available for npm via napi-rs📦 🥳