Potential fix for code scanning alert no. 3: Prototype-polluting assignment#17
Merged
owenrumney merged 1 commit intomainfrom Apr 30, 2026
Merged
Potential fix for code scanning alert no. 3: Prototype-polluting assignment#17owenrumney merged 1 commit intomainfrom
owenrumney merged 1 commit intomainfrom
Conversation
…gnment Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/owenrumney/go-lsp/security/code-scanning/3
Use a key/value structure that is safe for untrusted keys. The best minimal fix here is to change
entryByIdfrom plain-object indexing to aMap, and update all reads/writes in this file toset/getso special keys like__proto__are treated as normal map keys and cannot affect prototypes.In
internal/debugui/static/index.html, update:entryById[e.id] = e;→entryById.set(e.id, e);const req = entryById[e.pairedWith];→const req = entryById.get(e.pairedWith);Also update the
entryByIdinitialization line in the shown file tonew Map()(wherever it is currently declared as{}in this file). This preserves behavior while removing prototype-pollution risk.Suggested fixes powered by Copilot Autofix. Review carefully before merging.