Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Remove 'dispatch' message from phpstan.neon #1175

Merged
merged 1 commit into from
May 22, 2023

Conversation

phil-davis
Copy link
Contributor

Fixes #1174

The code for the EventDispatcherInterface::dispatch had already been updated for the Symfony 5 parameter order. Now that Symfony 5 is really in use in oC10 core, phpstan no longer complains about the order of the parameters.

Remove the error from ignoreErrors in phpstan.neon

@phil-davis phil-davis self-assigned this May 22, 2023
@phil-davis phil-davis changed the title [tests-only] Remove 'dispatch' message from phpstan.neon [full-ci] [tests-only] Remove 'dispatch' message from phpstan.neon May 22, 2023
@phil-davis phil-davis force-pushed the adjust-expected-phpstan-messages branch from 41735c5 to 5e37663 Compare May 22, 2023 05:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit bc4e4c9 into master May 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the adjust-expected-phpstan-messages branch May 22, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly failure in phpstan
2 participants