[SPACES] WebDAV permissions in files #3997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuancaG05
changed the title
10 tasks
abelgardep
changed the title
JuancaG05
changed the title
JuancaG05
force-pushed
the
spaces/folder_permissions
branch
from
c8266aa to
9ea907c
Compare
JuancaG05
force-pushed
the
spaces/file_permissions
branch
from
7f3772c to
903f82d
Compare
JuancaG05
force-pushed
the
spaces/file_permissions
branch
from
17c1525 to
0cdd283
Compare
abelgardep
suggested changes
Mar 31, 2023
owncloudApp/src/main/java/com/owncloud/android/files/FileMenuFilter.java
Outdated
Show resolved
Hide resolved
JuancaG05
force-pushed
the
spaces/file_permissions
branch
from
f7c613e to
b27bd4e
Compare
abelgardep
approved these changes
Mar 31, 2023
|
Some comments about QA, related with the exposed in the top message
|
|
Approved on my side |
…d send it to external apps without writing permission
abelgardep
force-pushed
the
spaces/file_permissions
branch
from
b27bd4e to
277ede3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #3890
In this PR we handle permissions related to files (for oC10 as well). Specifically, we handle these cases:
Wpermission (write), we show "Open with (read only)" instead of "Open with", in the main file list with only the file selected, in the details view and in its preview. Also, this file cannot be modified by external apps since we send it without the write permission flag. NOTE: oC10 always sendsWin the permissions although the file doesn't actually have it, so the error is handled in backend in this case (error message shown in the app)Rpermission (reshare), we hide the "Share" option in the main file list with only the file selected, in the details view and in its preview. NOTE: in oCIS accounts, at the moment it is not possible to share files from a space that is not the personal, so this option won't appear anywayThe next points do not apply to oC10 since there, a user can have lack of permissions over a file or folder only when it is shared with them, and when this occurs, a new synchronized copy of the file is created for them, so that they will always have these permissions because the operations apply to their local copy:
Dpermission (delete), we hide the "Remove" option in the main file list with the file selected (also if it is selected among some others), in the details view and in its previewNpermission (rename), we hide the "Rename" option in the main file list with only the file selected, in the details view and in its preview (in the preview wasn't shown before either, it is work to do)Vpermission (move), we hide the "Move" option in the main file list with only the file selected (also if it is selected among some others)QA