Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Adjust unit tests for Symfony 5 #40797

Merged
merged 2 commits into from
May 19, 2023
Merged

[tests-only] Adjust unit tests for Symfony 5 #40797

merged 2 commits into from
May 19, 2023

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 18, 2023 •
edited
Loading

Description

  1. Adjust Symfony OutputFormatterInterface in unit tests
  2. Adjust Symfony EventDispatcher dispatch method in unit tests

The tests continue to work fine with Symfony - for example, the EventDispatcher dispatch call in Symfony 4 supports the old and new way of calling it. In Symfony 5 only the new way is supported. So these changes get ready for Symfony 5 while still working properly with Symfony 4.

Related Issue

Preparation for #39630

How Has This Been Tested?

Local run of unit tests
CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this May 18, 2023
@phil-davis phil-davis force-pushed the adjust-unit-tests-for-symfony-5 branch from 7a19d31 to f7d7f9c Compare May 19, 2023 06:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis marked this pull request as ready for review May 19, 2023 06:47
@phil-davis phil-davis mentioned this pull request May 19, 2023
Merged
11 tasks
@phil-davis phil-davis merged commit 61a25cd into master May 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the adjust-unit-tests-for-symfony-5 branch May 19, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @jvillafanez