Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: php 8.2 #40981

Closed
wants to merge 37 commits into from
Closed

feat: php 8.2 #40981

wants to merge 37 commits into from

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Sep 18, 2023

Description

TODO

Not in scope of this PR

  • upgrade to phpunit 10.x

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Sep 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@phil-davis
Copy link
Contributor

owncloudci/php:8.2 is available now, I restarted drone CI.

@phil-davis
Copy link
Contributor

@DeepDiver1975 CI is working - I will leave you to look at the various things reported by phan, phpstan etc.
Ping if you want any input from me.

@DeepDiver1975 DeepDiver1975 force-pushed the feat/php8 branch 9 times, most recently from 9f6e161 to 30fa310 Compare October 2, 2023 10:39
@DeepDiver1975 DeepDiver1975 force-pushed the feat/php8 branch 4 times, most recently from e057fb1 to b9a2f86 Compare October 9, 2023 11:17
@DeepDiver1975 DeepDiver1975 force-pushed the feat/php8 branch 3 times, most recently from c699ce7 to b82b5b5 Compare October 11, 2023 13:20
@DeepDiver1975 DeepDiver1975 mentioned this pull request Oct 11, 2023
11 tasks
@DeepDiver1975 DeepDiver1975 reopened this Nov 23, 2023
@DeepDiver1975
Copy link
Member Author

cleaning up - I think this is no longer of anybody's interest

@hellwolf
Copy link

hellwolf commented Nov 19, 2024

no longer of anybody's interest

correction: no longer of interest of anybody from owncloud.

This is just infuriating, I guess I have just been a sucker that haven't prioritized the migration away from owncloud a priority.

Fwiw, I am also the packager of owncloud-client on nixpkgs.

This spells the end of this thing. But I guess that's what owncloud wanted!

@DeepDiver1975
Copy link
Member Author

This spells the end of this thing. But I guess that's what owncloud wanted!

The end of owncloud 10 was marked by the time all forces have been moved to infinite scale. It was quite obvious in all these years. Not really shocking - right?

@hellwolf
Copy link

That itself was not shocking.

The fact that this branch existed and now abandoned signals some change that you folks have all the rights to reserve to yourself. I get that, I guess many people get that. But that's the trust eroded that you won't get back anytime soon.

@DeepDiver1975 DeepDiver1975 deleted the feat/php8 branch November 19, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants