Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if running via SSH (no access to the keychain) #1412

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

matteocorti
Copy link

Description

When running the resign script via SSH the distribution certificate cannot be access since the keychain is locked.

The script now issues an error so that the user is advised to run the script in local shell.

Related Issue

Motivation and Context

When running the script via SSH the error message is not readily visible and the issue is not easy to be noticed.

How Has This Been Tested?

Tested while running in a local shell and via SSH

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Added an issue with details about all relevant changes in the iOS documentation repository.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

@hosy
Copy link
Collaborator

hosy commented Oct 23, 2024

@matteocorti Thank you so much for your contribution! This will help us and other customers avoid getting stuck on resigning issues.

@hosy hosy requested review from hosy and DeepDiver1975 October 23, 2024 15:51
@matteocorti
Copy link
Author

@matteocorti Thank you so much for your contribution! This will help us and other customers avoid getting stuck on resigning issues.

Actually, it appears that it should be possible to unlock the keychain via command line, but in my case I had some issues from time to time. As soon as I am sure, I will submit another patch.

@hosy
Copy link
Collaborator

hosy commented Oct 25, 2024

@matteocorti Would be great if you could increase the version number when committing new changes.

@matteocorti
Copy link
Author

matteocorti commented Oct 25, 2024

@matteocorti Would be great if you could increase the version number when committing new changes.

Now I see: the script has an own version ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants