[feature/server-side-search] Add server-side search support #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ProgressSummarizer: add support for new OCEventType .search
|
|
- add CollectionViewCellStyle.showPathDetails property - add CollectionViewCellStyle.StyleOptionKey.showPathDetails - OCItem+UniversalItemListCellContentProvider: add support for CollectionViewCellStyle.showPathDetails - ServerSideSearchScope: add server-side search scope - SearchScope: add convenience method to instantiate ServerSideSearchScope - ClientItemViewController: add server-side search scope
felix-schwarz
force-pushed
the
feature/server-side-search
branch
from
0843194 to
8ee4643
Compare
- "fix" keyword "spreadsheet" translation by matching the type alias rather than matching its start - add keyword "archive" translating into the "x-office/presentation" type alias - SearchScope: add support for specifying the searchable content and controlling the content to search (itemName, file contents) - ItemSearchScope: add subclassing point for creation of ItemSearchSuggestionsViewController() - ServerSideSearchScope: - make subclass of ItemSearchScope to simplify implementation - add support for OCKQLSearchedContent, allowing to select whether to search item name, content - or both - create adapted version of ItemSearchSuggestionsViewController() to omit size search suggestions (support in server unclear at the moment, waiting for clarification) - ItemSearchSuggestionsViewController: - allow excluding suggestion categories - add support for OCKQLSearchedContent (SearchScope.supportedSearchedContent + .searchedContent), including a toggle
…le with popup to allow searching terms only in names, only in contents - or name + content - ServerSideSearchScope: restore special cell style to also include path details
…ntiate them - SearchScope: - add new class property "descriptor" to allow each scope to return its own descriptor - subclasses: refactor to add "descriptor" implementations, encapsulating everything into its SearchScopeDescriptor that's needed to use each scope respectively, allowing to integrate a search scope with the rest of the app with a single line in SearchScopeDescriptor.all -SearchScope+Registry: extend SearchScope with: - a method to access available scopes based on context and cell style - a concept to allow users to pick a default scope and SearchedContent - ClientViewController: make use of the SearchScope.availableScopes() based on SearchScopeDescriptor.all
…Search Settings - SearchScope: add SearchScope.Identifier type - SearchScopeDescriptor: - change identifier type to SearchScope.Identifier - change access rights - change .title to .localizedName - add .localizedDescription - SearchScope+Registry: add class settings support, making a default scope configurable by MDM or through the user - ClientItemViewController, SearchViewController: add support for default scope - StaticTableViewRow: add icon support to multiple choice rows - update CONFIGURATION.json
…server-side search
… message that server-side search is not available if there's no connection, advise to use Account scope instead then
- check if server-side search and content-search are supported - and appear only then - resume/resend search requests if the connection comes (back) online - update ios-sdk for more extensive server-side search capability information
…t - or name+content) and reuse it next time the scope is invoked, default to name+content
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds server-side search support to the app.
TODO
OCSearchResultOCSearchResultOCQueryCondition(similar to the SQL syntax generator)possibly integrate/merge with account-wide searchRelated Issue
SDK part: owncloud/ios-sdk#129
Screenshots (if appropriate):
ownCloudTypes of changes