Skip to content

feat(external-sites): add 0.3.0 to the marketplace - #198

Open
LukasHirt wants to merge 1 commit into
mainfrom
publish/external-sites-v0.3.0
Open

feat(external-sites): add 0.3.0 to the marketplace#198
LukasHirt wants to merge 1 commit into
mainfrom
publish/external-sites-v0.3.0

Conversation

@LukasHirt

Copy link
Copy Markdown
Contributor

Submit to the ownCloud marketplace

What are you submitting?

  • An app (ownCloud Classic app)
  • An oCIS web extension
  • A publisher page

oCIS web extension

A web extension adds a release directory whose metadata is authored in
extension.yaml (oCIS reads it from the repository feed, not the bundle).

  • Extension id (the reverse-DNS id in extension.yaml): com.github.owncloud.web-extensions.external-sites
  • Folder slug (<ext-id>, also the release tag / asset name): external-sites
  • Version (the version in extension.yaml): 0.3.0
  • Files added: extensions/external-sites/releases/0.3.0/ containing bundle.zip
    (Git LFS) and extension.yaml and a screenshots/ dir.

Checklist

  • bundle.zip and extension.yaml are committed under extensions/external-sites/releases/0.3.0/.
  • The version in extension.yaml matches the releases/<version>/ directory name.
  • The reverse-DNS id is the same across every release of this extension.
  • This is a new release — I am not modifying or deleting an already-published release.
  • extension.yaml has at least one authors entry and at least one tags entry.

Built from web-extensions release external-sites-v0.3.0, reviewed locally via extctl publish before approval.

🤖 Generated by extctl publish

@LukasHirt
LukasHirt requested a review from a team as a code owner July 27, 2026 14:24
@DeepDiver1975

Copy link
Copy Markdown
Contributor

Holding this external-sites series for a metadata fix

Thanks — the bundles themselves are verified good: every bundle.zip in
#198#203 is byte-identical to the corresponding upstream
owncloud/web-extensions release asset (checked by sha256 against upstream's
published sha256sum.txt). CI is green and nothing is out of scope.

I'm holding the whole series rather than merging, because external-sites already
exists in the catalog and the feed takes its display fields from the newest
release (generate-extensions.ts).
Merging any of these would make the newest release the one shown publicly, and
that would regress what's live today:

on main today (0.2.0) these PRs
name External Sites External Sites
subtitle Add links to the app switcher (embedded or external). add external sites to the ownCloud Web app menu
cover image cover.png + cover: true missing

What's needed

  1. Add cover.png + cover: true to each release directory. The cover goes
    at the release-dir root (releases/<version>/cover.png), not inside
    screenshots/. Without it the oCIS app-store grid silently falls back to the
    first screenshot, and these extensions lose the cover art they have today.
  2. Restore the curated name and subtitle. The generator title-cases the
    folder slug, which turns Draw.io into Draw Io and JSON Viewer into
    Json Viewer, and replaces written subtitles with the upstream
    package.json description. Please carry over the existing curated strings.
  3. Commit the binaries through Git LFS. .gitattributes marks
    extensions/**/*.zip and *.png as filter=lfs and every release currently
    on main complies (e.g. unzip/0.3.0/bundle.zip is a 130-byte pointer), but
    these PRs contain the raw bytes in-tree. Looks like an extctl issue — see
    the tracking issue linked below.

One thing to keep: the license change from AGPL-3.0 to Apache-2.0 is
correct. Upstream is genuinely Apache-2.0 (repo license and per-package
package.json), so main is the stale side here.

Leaving these open — no need to reopen anything once you re-push.

Tracking issue for the LFS point: #238

@LukasHirt
LukasHirt force-pushed the publish/external-sites-v0.3.0 branch 2 times, most recently from 3c67242 to 0b5d649 Compare August 28, 2026 12:43
Signed-off-by: Lukas Hirt <info@hirt.cz>
@LukasHirt
LukasHirt force-pushed the publish/external-sites-v0.3.0 branch from 0b5d649 to 886c7e7 Compare August 28, 2026 12:53
@LukasHirt

Copy link
Copy Markdown
Contributor Author

Thanks for the review — this has been updated in place on the same branch (amended commit, force-pushed), not regenerated:

  • name / subtitle: restored to the curated values already published for this extension (no longer the generator's title-cased slug / upstream package.json description).
  • cover: cover: true + cover.png added at the release root, matching the cover art already live for this extension.
  • Git LFS: bundle.zip and the screenshots are now committed as real LFS pointers (content byte-identical to before — same hash you already sha256-verified).
  • minOCIS: 7.0.0 — this release predates the extension's own e2e test (only added starting the next version), so there was nothing to run automatically. I manually built and tested this exact release against a real oCIS 7.0.0 instance in a browser and confirmed the extension works correctly.

Ready for another look whenever you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants