feat(json-viewer): add 0.3.0 to the marketplace - #213
Conversation
Holding this
|
on main today (0.2.0) |
these PRs | |
|---|---|---|
name |
JSON Viewer |
Json Viewer |
subtitle |
View JSON files (.json) with syntax highlighting and collapsible nodes. |
ownCloud Web json-viewer |
| cover image | cover.png + cover: true |
missing |
What's needed
- Add
cover.png+cover: trueto each release directory. The cover goes
at the release-dir root (releases/<version>/cover.png), not inside
screenshots/. Without it the oCIS app-store grid silently falls back to the
first screenshot, and these extensions lose the cover art they have today. - Restore the curated
nameandsubtitle. The generator title-cases the
folder slug, which turnsDraw.iointoDraw IoandJSON Viewerinto
Json Viewer, and replaces written subtitles with the upstream
package.jsondescription. Please carry over the existing curated strings. - Commit the binaries through Git LFS.
.gitattributesmarks
extensions/**/*.zipand*.pngasfilter=lfsand every release currently
onmaincomplies (e.g.unzip/0.3.0/bundle.zipis a 130-byte pointer), but
these PRs contain the raw bytes in-tree. Looks like anextctlissue — see
the tracking issue linked below.
One thing to keep: the license change from AGPL-3.0 to Apache-2.0 is
correct. Upstream is genuinely Apache-2.0 (repo license and per-package
package.json), so main is the stale side here.
Leaving these open — no need to reopen anything once you re-push.
Tracking issue for the LFS point: #238
e26bc1b to
bd5aad5
Compare
Signed-off-by: Lukas Hirt <info@hirt.cz>
bd5aad5 to
0186607
Compare
|
Thanks for the review — this has been updated in place on the same branch (amended commit, force-pushed), not regenerated:
Ready for another look whenever you have time. |
Submit to the ownCloud marketplace
What are you submitting?
oCIS web extension
A web extension adds a release directory whose metadata is authored in
extension.yaml(oCIS reads it from the repository feed, not the bundle).idin extension.yaml):com.github.owncloud.web-extensions.json-viewer<ext-id>, also the release tag / asset name):json-viewerversionin extension.yaml):0.3.0extensions/json-viewer/releases/0.3.0/containingbundle.zip(Git LFS) and
extension.yamland ascreenshots/dir.Checklist
bundle.zipandextension.yamlare committed underextensions/json-viewer/releases/0.3.0/.versioninextension.yamlmatches thereleases/<version>/directory name.idis the same across every release of this extension.extension.yamlhas at least oneauthorsentry and at least onetagsentry.Built from web-extensions release
json-viewer-v0.3.0, reviewed locally viaextctl publishbefore approval.🤖 Generated by extctl publish