Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Tests for availability of resources shared with Denied role while listing all drives #10721

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[tests-only][full-ci] Tests for availability of resources shared with Denied role while listing all drives #10721

merged 1 commit into from
Jan 22, 2025

Conversation

anon-pradip
Copy link
Contributor

@anon-pradip anon-pradip commented Dec 4, 2024 •
edited
Loading

Description

This PR

  • verifies that the resources, in both personal and project spaces, shared with denied permission roles don't appear while sharee lists all drives.
  • Adds OcisConfigContext context for the suite apiSharingNgShareInvitation.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI
  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@anon-pradip anon-pradip self-assigned this Dec 4, 2024
@anon-pradip anon-pradip mentioned this pull request Dec 4, 2024
Open
7 tasks
@anon-pradip
Copy link
Contributor Author

anon-pradip commented Dec 16, 2024 •
edited
Loading

This PR is subsequent to the PR: #10696. So waiting for that to be merged.
This PR is subsequent to the PR: #10703. So waiting for that to be merged.

@anon-pradip anon-pradip force-pushed the list-all-drives branch 3 times, most recently from 6dad5e5 to f73bf0b Compare December 24, 2024 06:08
@anon-pradip
Copy link
Contributor Author

Making it ready for review since #10703 is merged.

@anon-pradip anon-pradip marked this pull request as ready for review January 6, 2025 06:44
@anon-pradip anon-pradip force-pushed the list-all-drives branch 2 times, most recently from 2e2ce25 to 0f08ce6 Compare January 6, 2025 08:45
@anon-pradip anon-pradip force-pushed the list-all-drives branch 2 times, most recently from ea883ac to f12ca03 Compare January 6, 2025 10:21
SagarGi
SagarGi reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anon-pradip anon-pradip requested a review from saw-jan January 7, 2025 06:56
nabim777
nabim777 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@nabim777 nabim777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anon-pradip anon-pradip requested a review from saw-jan January 7, 2025 10:15
@anon-pradip anon-pradip force-pushed the list-all-drives branch 3 times, most recently from 9eed467 to 987ea0f Compare January 21, 2025 09:43
amrita-shrestha
amrita-shrestha reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm me but how about adding coverage for resource inside project/space

@anon-pradip anon-pradip requested a review from saw-jan January 21, 2025 09:46
@anon-pradip
Copy link
Contributor Author

lgtm me but how about adding coverage for resource inside project/space

Added 🚀

@anon-pradip anon-pradip changed the title [tests-only][full-ci] Tests for listing drives after sharing resource with Denied role [tests-only][full-ci] Tests for availability of resources shared with Denied role while listing all drives Jan 21, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

amrita-shrestha
amrita-shrestha approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

S-Panta
S-Panta approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@S-Panta S-Panta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saw-jan saw-jan merged commit b783444 into master Jan 22, 2025
4 checks passed
@saw-jan saw-jan deleted the list-all-drives branch January 22, 2025 10:13
ownclouders pushed a commit that referenced this pull request Jan 22, 2025
@saw-jan
Merge pull request #10721 from owncloud/list-all-drives
23dbae7 
[tests-only][full-ci] Tests for availability of resources shared with Denied role while listing all drives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@S-Panta S-Panta S-Panta approved these changes

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@saw-jan saw-jan saw-jan approved these changes

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nabim777 nabim777 Awaiting requested review from nabim777

Assignees

@anon-pradip anon-pradip

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anon-pradip @SagarGi @saw-jan @amrita-shrestha @nabim777 @S-Panta