Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] added test to remove access to share after the share role has been disabled #10759

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

PrajwolAmatya
Copy link
Contributor

Description

This PR adds the test to remove access to share after the share role has been disabled.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but do we have tests coverage for group sharee

@PrajwolAmatya
Copy link
Contributor Author

lgtm but do we have tests coverage for group sharee

We don't but is it necessary for these cases?

@amrita-shrestha
Copy link
Contributor

lgtm but do we have tests coverage for group sharee

We don't but is it necessary for these cases?

yeah need to add test for group too but You can do that in next PR

@PrajwolAmatya PrajwolAmatya merged commit e22c355 into master Dec 23, 2024
4 checks passed
@PrajwolAmatya PrajwolAmatya deleted the delete-share branch December 23, 2024 03:24
ownclouders pushed a commit that referenced this pull request Dec 23, 2024
[tests-only][full-ci] added test to remove access to share after the share role has been disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants