[tests-only][full-ci] added test to update share role to existing role after the assigned share role is disabled #10760
+168
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
PrajwolAmatya
force-pushed
the
update-share-role
branch
2 times, most recently
from
97814fa to
6f7d42a
Compare
PrajwolAmatya
requested review from
anon-pradip,
ishabaral,
SagarGi,
saw-jan,
prashant-gurung899,
Salipa-Gurung,
amrita-shrestha,
nabim777,
S-Panta and
nirajacharya2
PrajwolAmatya
force-pushed
the
update-share-role
branch
from
6f7d42a to
f52514b
Compare
tests/acceptance/features/apiSharingNgShareInvitation/updateShareInvitations.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiSharingNgShareInvitation/updateShareInvitations.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
force-pushed
the
update-share-role
branch
2 times, most recently
from
a8dc67b to
13e34ac
Compare
PrajwolAmatya
force-pushed
the
update-share-role
branch
5 times, most recently
from
be48232 to
892d1a6
Compare
saw-jan
requested changes
Dec 23, 2024
tests/acceptance/features/apiSharingNgShareInvitation/updateShareInvitations.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
requested review from
ishabaral,
SagarGi,
saw-jan,
prashant-gurung899,
Salipa-Gurung,
amrita-shrestha,
nabim777,
S-Panta and
nirajacharya2
Ready for review 👀 |
nabim777
reviewed
Jan 9, 2025
PrajwolAmatya
force-pushed
the
update-share-role
branch
from
211dfd2 to
6e83496
Compare
PrajwolAmatya
force-pushed
the
update-share-role
branch
from
6e83496 to
f687054
Compare
|
LGTM 👍 |
PrajwolAmatya
force-pushed
the
update-share-role
branch
3 times, most recently
from
95ead98 to
eef0ee2
Compare
saw-jan
reviewed
Jan 13, 2025
| | space | Personal | | ||
| | resource | <resource> | | ||
| Then the HTTP status code should be "200" | ||
| And the updated permissions role of the last share should be "<permissions-role>" |
There was a problem hiding this comment.
is it like checking the response object?
Suggested change
| And the updated permissions role of the last share should be "<permissions-role>" | |
| And the updated permissions role of the last share should be "<permissions-role>" |
There was a problem hiding this comment.
Not the whole response, but only the value of the role id.
PrajwolAmatya
force-pushed
the
update-share-role
branch
from
eef0ee2 to
cfb1a42
Compare
PrajwolAmatya
force-pushed
the
update-share-role
branch
from
cfb1a42 to
2e447b4
Compare
PrajwolAmatya
force-pushed
the
update-share-role
branch
from
2e447b4 to
7bf3f72
Compare
|
ownclouders
pushed a commit
that referenced
this pull request
Jan 14, 2025
[tests-only][full-ci] added test to update share role to existing role after the assigned share role is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test to update share role to an existing role after the assigned share role is disabled. This PR covers the test for updating the roles to:
Secure Viewerto other existing permissions role (Personal Space resource)Secure Viewerto other existing permissions role (Project Space resource)Space Editor Without Versionsto other existing permissions roleCurrently, trying to update the permissions role from
Deniedto other existing permissions role takes more than30seconds to sync, which makes the tests execution longer. So, currently scenario related to updating the permissions role fromDeniedto other roles has been removed from this PR and will be added on the next PR and move this PR forward as this PR has been on hold for long time.Related Issue
Types of changes
Checklist: