[full-ci][tests-only]Add support to stop and start service in ociswrapper #10776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
force-pushed
the
add-support-to-stop-and-start-service-in-ociswrapper
branch
3 times, most recently
from
2125c45 to
b3c2e20
Compare
|
|
amrita-shrestha
force-pushed
the
add-support-to-stop-and-start-service-in-ociswrapper
branch
5 times, most recently
from
cc95565 to
5f509bd
Compare
1 task
amrita-shrestha
force-pushed
the
add-support-to-stop-and-start-service-in-ociswrapper
branch
3 times, most recently
from
43f62bd to
27074ac
Compare
saw-jan
requested changes
Jan 10, 2025
amrita-shrestha
force-pushed
the
add-support-to-stop-and-start-service-in-ociswrapper
branch
from
df7c67f to
296bdb6
Compare
amrita-shrestha
force-pushed
the
add-support-to-stop-and-start-service-in-ociswrapper
branch
2 times, most recently
from
e78d3cc to
d7778d4
Compare
amrita-shrestha
requested review from
saw-jan,
nirajacharya2,
PrajwolAmatya and
ishabaral
amrita-shrestha
force-pushed
the
add-support-to-stop-and-start-service-in-ociswrapper
branch
from
7a826fa to
d7c4771
Compare
saw-jan
reviewed
Jan 23, 2025
| serviceEnvMap = append(serviceEnvMap, fmt.Sprintf("%s=%v", key, value)) | ||
| } | ||
|
|
||
| log.Println(fmt.Sprintf("[ociswrapper] Starting oCIS service %s......", serviceName)) |
There was a problem hiding this comment.
Please, use the local logger: https://github.com/owncloud/ocis/blob/d7c47719c960ba781be0422335e09556ef937521/tests/ociswrapper/log/log.go
saw-jan
reviewed
Jan 23, 2025
amrita-shrestha
requested review from
kobergj,
phil-davis and
individual-it
as code owners
amrita-shrestha
force-pushed
the
add-support-to-stop-and-start-service-in-ociswrapper
branch
4 times, most recently
from
d50e565 to
26019b2
Compare
amrita-shrestha
force-pushed
the
add-support-to-stop-and-start-service-in-ociswrapper
branch
4 times, most recently
from
54d170c to
0251708
Compare
amrita-shrestha
force-pushed
the
add-support-to-stop-and-start-service-in-ociswrapper
branch
from
0251708 to
b8dc144
Compare
|
saw-jan
reviewed
Jan 27, 2025
|
|
||
| @env-config | ||
| Scenario: check services health and readiness while running separately | ||
| Given the administrator has started service "audit" separately with the following config: |
There was a problem hiding this comment.
Suggested change
| Given the administrator has started service "audit" separately with the following config: | |
| Given the administrator has started service "audit" separately with the following configs: |
| * @return ResponseInterface | ||
| * @throws GuzzleException | ||
| */ | ||
| public static function startService(string $service, array $envs): ResponseInterface { |
There was a problem hiding this comment.
env can have default value
Suggested change
| public static function startService(string $service, array $envs): ResponseInterface { | |
| public static function startService(string $service, array $envs = []): ResponseInterface { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds new feature on ocis wrapper to stop/ start sevices.
Related Issue
Motivation and Context
How Has This Been Tested?
curl -XPOST 'http://localhost:5200/services/storage-users' -d'{"OCIS_LOG_LEVEL":"info"}'curl -XDELETE 'http://localhost:5200/services/storage-users'Screenshots (if appropriate):
Types of changes
Checklist: