Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] shift existing settings api test scenarios to apiSettings test suite #10841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Jan 9, 2025

Description

This PR

  • Shifts already existing settings API test scenarios into apiSettings test suite.
  • Removes the following scenarios
Scenario Outline: get assigned role of a user via setting api
Scenario Outline: only admin user can see assignments list
Scenario Outline: only admin user can see all existing roles

as they are covered in

Scenario Outline: user lists assignments
Scenario Outline: user lists existing roles

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this feature file but change tests to use graph

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suite is a special one.

@prashant-gurung899 prashant-gurung899 force-pushed the test/shift-settings-scenarios branch from 7d4b953 to 6b3711c Compare January 13, 2025 07:02
@prashant-gurung899 prashant-gurung899 force-pushed the test/shift-settings-scenarios branch from 6b3711c to b078841 Compare January 13, 2025 08:22
@prashant-gurung899 prashant-gurung899 force-pushed the test/shift-settings-scenarios branch from b078841 to 69895b5 Compare January 14, 2025 04:07
Comment on lines -7 to -20
Scenario Outline: only admin user can see all existing roles
Given user "Alice" has been created with default attributes
And the administrator has given "Alice" the role "<user-role>" using the settings api
When user "Alice" tries to get all existing roles using the settings API
Then the HTTP status code should be "<http-status-code>"
Examples:
| user-role | http-status-code |
| Admin | 201 |
| Space Admin | 201 |
| User | 201 |

@issue-5032
Scenario Outline: only admin user can see assignments list
Given user "Alice" has been created with default attributes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update these scenarios into graph and then we don't have to remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants