Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] use displayname of permissions role in resource link share creation step #10850

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Jan 10, 2025

Description

This PR refactors the resource link share creation steps such that the datatable uses permissions roles displayName. Previously, permissions role value was used.

In this PR following are the changes made in datatable:

from view => to View
from internal => to Internal
from edit => to Edit
from upload => to Upload
from createOnly => to File Drop
from blocksDownload => to Secure View

See: https://owncloud.dev/libre-graph-api/#/drives.permissions/CreateLink

Refactored steps:

Given user "Alice" has created the following resource link share:

And user "Alice" has updated the last resource link share with

When user "Alice" updates the last public link share using the permissions endpoint of the Graph API:

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 self-assigned this Jan 10, 2025
@prashant-gurung899 prashant-gurung899 force-pushed the test/use-displayname-perm-role branch 7 times, most recently from f856eaf to 1eea6b7 Compare January 13, 2025 10:31
@prashant-gurung899 prashant-gurung899 changed the title [tests-only][full-ci] use displayname of permissions role in steps [tests-only][full-ci] use displayname of permissions role in resource link share creation step Jan 13, 2025
@prashant-gurung899
Copy link
Contributor Author

@saw-jan
Should I refactor the space link share creation step in this same PR or do it in another one as the no. of files changed is quite a lot in this one already.

And user "Alice" has created the following space link share:

@prashant-gurung899 prashant-gurung899 force-pushed the test/use-displayname-perm-role branch 2 times, most recently from 826008d to 071aef6 Compare January 14, 2025 04:53
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review January 14, 2025 06:34
@prashant-gurung899 prashant-gurung899 force-pushed the test/use-displayname-perm-role branch from 071aef6 to 718ffda Compare January 14, 2025 09:36
@prashant-gurung899
Copy link
Contributor Author

@saw-jan Should I refactor the space link share creation step in this same PR or do it in another one as the no. of files changed is quite a lot in this one already.

And user "Alice" has created the following space link share:

IMO this should be done in next PR. CC @saw-jan

@prashant-gurung899 prashant-gurung899 force-pushed the test/use-displayname-perm-role branch from 718ffda to 5adfb3e Compare January 14, 2025 09:58
@prashant-gurung899 prashant-gurung899 force-pushed the test/use-displayname-perm-role branch from 5adfb3e to 79213b0 Compare January 14, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants