Rename role for consistency (leftover from change in v3) #10871
Merged
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmattel
force-pushed
the
rename_bunlde_for_consistency
branch
from
819f29e to
4aab3a2
Compare
|
2403905
approved these changes
Jan 14, 2025
ownclouders
pushed a commit
that referenced
this pull request
Jan 14, 2025
Rename role for consistency (leftover from change in v3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #10870 (Transition from 'Guest' user to 'User Light' was incomplete in terms of translatable strings)
This PR does most likely not fix the issue completely, but contributes to make things consistable and understandable.
The change was defined in: https://github.com/owncloud/ocis/blob/9e1fe81069b526d76ed4da5d8044cb03ca3e1a4c/changelog/3.0.0_2023-06-06/rename-guest-role.md?plain=1
Note that the UUID's of the roles are the same.
roleId = settingsService.BundleUUIDRoleGuest-->roleId = settingsService.BundleUUIDRoleUserLightBundleUUIDRoleGuestwithBundleUUIDRoleUserLightinservices/settings/pkg/service/v0/settings.go